Skip to content

RT-1.15: Reduce OTG learned-prefix and route overhead - #5764

Open
jjw-a-0617 wants to merge 1 commit into
openconfig:mainfrom
jjw-a-0617:rt_1_15
Open

RT-1.15: Reduce OTG learned-prefix and route overhead#5764
jjw-a-0617 wants to merge 1 commit into
openconfig:mainfrom
jjw-a-0617:rt_1_15

Conversation

@jjw-a-0617

Copy link
Copy Markdown
Contributor

Limit learned-prefix collection to port4 and use counted route ranges for IPv4 advertisements.

This reduces OTG resource usage while preserving test settings.

Limit learned-prefix collection to port4 and use counted route ranges
for IPv4 advertisements.

This reduces OTG resource usage while preserving test settings.
@jjw-a-0617
jjw-a-0617 requested a review from a team as a code owner July 26, 2026 06:48
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes OTG resource usage in BGP scale tests by refining how learned prefixes are filtered and how routes are advertised. By limiting prefix collection to specific ports and switching to counted route ranges, the test suite becomes more efficient while maintaining existing test coverage.

Highlights

  • Learned Information Filtering: Restricted learned-prefix collection to only occur on 'port4' to reduce resource overhead.
  • Route Advertisement Optimization: Replaced individual prefix iterations with counted route ranges for IPv4 advertisements to improve performance.
  • Code Refactoring: Introduced a helper function for adding BGP communities to simplify route configuration logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the BGP scale test by restricting the learned information filters to 'port4' and replacing dynamic IPv4 prefix generation with hardcoded ranges and counts. It also introduces a helper function to simplify adding BGP communities. The reviewer identified a critical issue where the lack of explicit increment steps for the route ranges causes OTG to default to '0.0.0.1', resulting in overlapping subnets and fewer advertised prefixes than expected. Suggestions were provided to set appropriate step values for each prefix length.

Comment thread feature/bgp/addpath/otg_tests/addpath_scale/addpath_scale_test.go
Comment thread feature/bgp/addpath/otg_tests/addpath_scale/addpath_scale_test.go
Comment thread feature/bgp/addpath/otg_tests/addpath_scale/addpath_scale_test.go
Comment thread feature/bgp/addpath/otg_tests/addpath_scale/addpath_scale_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants