RT-1.15: Reduce OTG learned-prefix and route overhead - #5764
Conversation
Limit learned-prefix collection to port4 and use counted route ranges for IPv4 advertisements. This reduces OTG resource usage while preserving test settings.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes OTG resource usage in BGP scale tests by refining how learned prefixes are filtered and how routes are advertised. By limiting prefix collection to specific ports and switching to counted route ranges, the test suite becomes more efficient while maintaining existing test coverage. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5764 / 579bbf9Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request refactors the BGP scale test by restricting the learned information filters to 'port4' and replacing dynamic IPv4 prefix generation with hardcoded ranges and counts. It also introduces a helper function to simplify adding BGP communities. The reviewer identified a critical issue where the lack of explicit increment steps for the route ranges causes OTG to default to '0.0.0.1', resulting in overlapping subnets and fewer advertised prefixes than expected. Suggestions were provided to set appropriate step values for each prefix length.
Limit learned-prefix collection to port4 and use counted route ranges for IPv4 advertisements.
This reduces OTG resource usage while preserving test settings.