feat(refinement): add InterpreterState.isRefinedByAt relation#979
Open
math-fehr wants to merge 1 commit into
Open
feat(refinement): add InterpreterState.isRefinedByAt relation#979math-fehr wants to merge 1 commit into
InterpreterState.isRefinedByAt relation#979math-fehr wants to merge 1 commit into
Conversation
8932f56 to
19048aa
Compare
Contributor
There was a problem hiding this comment.
VeIR Benchmarks
Details
| Benchmark suite | Current: ae9b5a7 | Previous: f446e17 | Ratio |
|---|---|---|---|
add-fold-worklist/create |
2235000 ns (± 47758) |
2227000 ns (± 64073) |
1.00 |
add-fold-worklist/rewrite |
4014000 ns (± 55931) |
3949000 ns (± 25607) |
1.02 |
add-fold-worklist-local/create |
2259000 ns (± 110582) |
2343000 ns (± 125329) |
0.96 |
add-fold-worklist-local/rewrite |
3306500 ns (± 45252) |
3297000 ns (± 40575) |
1.00 |
add-zero-worklist/create |
2203000 ns (± 110519) |
2400000 ns (± 100685) |
0.92 |
add-zero-worklist/rewrite |
2561000 ns (± 17517) |
2538000 ns (± 26987) |
1.01 |
add-zero-reuse-worklist/create |
1844000 ns (± 91841) |
2053000 ns (± 137327) |
0.90 |
add-zero-reuse-worklist/rewrite |
2135000 ns (± 26968) |
2118500 ns (± 27380) |
1.01 |
mul-two-worklist/create |
2273500 ns (± 109478) |
2453000 ns (± 104488) |
0.93 |
mul-two-worklist/rewrite |
5606000 ns (± 45084) |
5519000 ns (± 57665) |
1.02 |
add-fold-forwards/create |
2257000 ns (± 106755) |
2362500 ns (± 145489) |
0.96 |
add-fold-forwards/rewrite |
3072000 ns (± 24260) |
3005500 ns (± 51759) |
1.02 |
add-zero-forwards/create |
2248000 ns (± 41823) |
2445000 ns (± 69270) |
0.92 |
add-zero-forwards/rewrite |
1984000 ns (± 23791) |
1936000 ns (± 38402) |
1.02 |
add-zero-reuse-forwards/create |
1816000 ns (± 44825) |
1941500 ns (± 121897) |
0.94 |
add-zero-reuse-forwards/rewrite |
1581000 ns (± 11389) |
1557000 ns (± 31073) |
1.02 |
mul-two-forwards/create |
2254000 ns (± 70960) |
2411000 ns (± 114728) |
0.93 |
mul-two-forwards/rewrite |
3724000 ns (± 41794) |
3609000 ns (± 34087) |
1.03 |
add-zero-reuse-first/create |
1848000 ns (± 95755) |
2009500 ns (± 179486) |
0.92 |
add-zero-reuse-first/rewrite |
8000 ns (± 3458) |
8000 ns (± 1270) |
1 |
add-zero-lots-of-reuse-first/create |
1801000 ns (± 67322) |
2005000 ns (± 19741) |
0.90 |
add-zero-lots-of-reuse-first/rewrite |
798000 ns (± 11194) |
764000 ns (± 18474) |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
0d582b5 to
c77698d
Compare
111c327 to
b52a484
Compare
c77698d to
66a8c5b
Compare
It differs to `isRefinedBy` by requiring values between states to refine each others only if they are dominated by the "refinement point". This new definition will superceed `isRefinedBy`, as it can handle things like looks that `isRefinedBy` cannot handle (as some "old" values stay in the state).
66a8c5b to
ae9b5a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It differs to
isRefinedByby requiring values between states to refine each others only if they are dominated by the "refinement point".This new definition will superceed
isRefinedBy, as it can handle things like looks thatisRefinedBycannot handle (as some "old" values stay in the state).