cadc-util: tweak error handling#288
Merged
Merged
Conversation
add PermissionDeniedException to replace deprecated AccessControlException
andamian
reviewed
Jun 17, 2026
| timeoutRetryDelay = Math.max(connectionTimeout, readTimeout) / 1000; // ms to sec | ||
| } | ||
| throw new TransientException("connection/read timeout: " + url, ex, timeoutRetryDelay); | ||
| throw new TransientException("url=" + toLoggableString(url) + " connection/read timeout"); |
Contributor
There was a problem hiding this comment.
This is not subject to the same retry rules like the other Transient exceptions?
Member
Author
There was a problem hiding this comment.
it turned out that computing the retry-after from the timeout values made for very long retry loops (because the timeouts can't be that short)... and this is client-side error handling so shouldn't guess at retry-after times... just use the default 1, 2, 4, ... seconds
andamian
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add PermissionDeniedException to replace deprecated AccessControlException