Skip to content

CADC-14932: Fixed cadc-quailty and checkstyle to work with gradle 8 and current gradle wrapper - 6.8.3. #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdowler merged 6 commits into from
Feb 24, 2026
Merged

CADC-14932: Fixed cadc-quailty and checkstyle to work with gradle 8 and current gradle wrapper - 6.8.3. #282

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2afbc7d
Upgraded checkstyle and java version.
aratikakadiya Feb 23, 2026
b8d55e5
Revert checkstyle and java version. Keeping the fix.
aratikakadiya Feb 24, 2026
7ca1680
Small change.
aratikakadiya Feb 24, 2026
2edaa92
Small change.
aratikakadiya Feb 24, 2026
d54f445
Small change.
aratikakadiya Feb 24, 2026
ec06e43
Small change.
aratikakadiya Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cadc-quality/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ repositories {

apply from: '../opencadc.gradle'

sourceCompatibility = 1.8
sourceCompatibility = 11

group = 'org.opencadc'

version = '1.0'
version = '1.1'

@pdowler pdowler Feb 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should still be usable, so version 1.0.1 would be approp here


description = 'OpenCADC Checkstyle Code Quality Rules'
def git_url = 'https://github.com/opencadc/core'
Expand Down
4 changes: 2 additions & 2 deletions opencadc.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ configurations {

dependencies {
testImplementation 'com.puppycrawl.tools:checkstyle:8.2'
checkstyleDep 'org.opencadc:cadc-quality:[1.0,)'
checkstyleDep 'org.opencadc:cadc-quality:[1.0,1.1)'
}

checkstyle {
Expand All @@ -34,7 +34,7 @@ sourceSets {
tasks.withType(Checkstyle).each { checkstyleTask ->
checkstyleTask.doLast {
reports.all { report ->
def outputFile = report.destination
def outputFile = report.outputLocation.get().asFile
if (outputFile.exists() && outputFile.text.contains("<error ")) {
throw new GradleException("There were checkstyle warnings! For more info check $outputFile")
}
Expand Down