Repository navigation
rekor: migrate v2 transparency entries from dsse to hashedrekord - #231
Merged
Merged
Conversation
Add rvps/rustfmt.toml so rustfmt does not reformat src/rvps_api/reference.rs (@generated by prost-build). Each prost-build regen diverges from rustfmt's style, so reformatting the committed file produces noisy diffs. `ignore` is an unstable rustfmt option that takes effect under the nightly rustfmt used in CI (.github/workflows/rust-check.yml) and is a no-op (with a warning) on stable. Assisted-by: Claude:glm-5.2
…rekord
log2025-1.rekor.sigstore.dev (Rekor v2) now rejects the deprecated
dsseRequestV002 entry type with "invalid type, must be hashedrekord",
breaking make test-dep-as and any flow that writes a DSSE entry to the
v2 log. Per Rekor's deprecation note ("use the hash of the DSSE PAE"),
post a hashedRekordRequestV002 entry whose digest is sha256(DSSE PAE)
and whose signature is the existing DSSE signature (ECDSA-SHA256 over
the PAE equals a signature over sha256(PAE)). No re-signing or
trust-model change; the DSSE envelope and its verification are
unchanged.
- rv-release-tool upload_rekor_v2 and as-signer-transparency
upload_rekor_v2: post hashedRekordRequestV002 (digest = sha256(PAE),
reuse the DSSE signature, same SPKI public key).
- as-signer-transparency: embed rekor.pae_sha256 (= sha256(PAE)) in the
signer_transparency bundle and set request_type to
hashedRekordRequestV002, so the verifier can bind the entry without
reconstructing the PAE bytes (the bundle carries the parsed payload,
not the raw signed bytes).
- rvps verify_rekor_v2_consistency (lib.rs and release_manifest.rs):
add a hashedrekord branch that reconstructs the PAE from the
dsseEnvelope's payloadType + payload and compares sha256(PAE) to the
entry's hashedRekordV002.data.digest. The legacy dsse branch is kept.
- New dsse_pae helper in rvps/src/lib.rs.
Tests: verify_rekor_v2_consistency hashedrekord accept/reject in both
lib.rs and release_manifest.rs, plus a real-fixture test against a
genuine log2025-1 hashedrekord/0.0.2 entry
(rvps/tests/fixtures/rekor_v2_hashedrekord_bundle.json); both uploads
verified live against log2025-1 (HTTP 201, hashedrekord/0.0.2).
Assisted-by: Claude:glm-5.2
|
@imlk0 ,您好,您的请求已接收,请耐心等待结果。 |
|
@imlk0 ,您好,未检测到有镜像需要构建,如需重新检测请评论 /start 。 |
jialez0
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log2025-1.rekor.sigstore.devnow rejects newdsseRequestV002entries with "invalid type, must be hashedrekord", breakingrv-release-tooland any flow that writes a DSSE entry to the v2 log. This PR migrates the v2 write and read paths tohashedRekordRequestV002.Reproduce (pre-fix fails with the error; post-fix returns HTTP 201 and a hashedrekord/0.0.2 entry):