Repository navigation
fix: bound authentication and cancellation records in the Realtime demo - #2182
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved at 9b86a6e. Reviewed all eight changed files and surrounding session/authentication lifecycle. Principal admission is capped before allocation, existing principals renew at capacity, and expiry sweeps are bounded. Session capacity counts live IDs and cancellation tombstones once, preserving ownership checks, delayed-setup rejection and cleanup/retry for admitted sessions even with pending hangup. Tests cover these boundaries.
Coordinator and independent static review found no actionable issues; existing feedback checked. Hosted CI remains pending. No candidate code, tests, builds or CI reruns executed.
Summary
The server-controlled Realtime demo could store authentication and cancellation records without a limit. It now caps demo principals and clears expired entries. It also caps the number of distinct live and cancelled session IDs.
The server returns HTTP 503 when it cannot admit a new ID. Existing principals can renew, and active sessions can still close at capacity. Cancelled IDs stay recorded until restart so late setup cannot reuse them. If those records fill the session budget, the demo needs a restart to accept new sessions.
Please review the admission limits and the order of setup and cancellation.
Test plan
Checks
.agents/skills/code-change-verification/scripts/run.sh.