Repository navigation
Skip release contract fixtures in SDK coverage - #2180
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved. The exclusion applies only to the coverage invocation. Node 22 and 24.3.x still run the full suite including release-contract fixtures, while SDK source coverage selection and enforcement thresholds remain unchanged.
Reviewed commit d8c819f. Static review with an independent reviewer; no candidate code or tests were run. Hosted CI follow-up remains tracked separately.
|
Hosted CI complete at d8c819f: all eight checks passed, including coverage, both Node test versions and all three native package platforms. The PR is merged; closing CI follow-up. No candidate code/tests or CI reruns were executed locally. |
The SDK coverage job timed out in a fixture that checks TypeScript release declarations. The Node 22 and Node 24 jobs both passed all 97 release contract cases on the same commit. Coverage failure · Node 22 · Node 24
This change skips that fixture file in the coverage job. The ordinary test jobs still run every release contract case on both Node versions. Vitest still collects all 343 SDK package test files for coverage, and CI enforces the same thresholds.
Running the 97 release contract cases alone took 4m33s and covered zero lines, branches, functions, or statements across 434 SDK source files.
On GitHub, the coverage step took 1m40s, down from 3m15s on #2177's green retry. The coverage job took 3m08s, down from 4m29s. All four thresholds passed. Both Node versions passed all 97 release contract cases and the Prisma memory tests. CI on this change · Previous green coverage job
The full workflow finished in 5m57s versus 9m24s on #2177's first attempt. Node 22 finished last on both runs. It started 65 seconds earlier and ran 142 seconds faster on this run, accounting for the full-workflow difference.
The CI build and coverage commands passed locally. Vitest passed 9,444 tests, and the released SDK passed all four coverage thresholds. The full local wrapper stopped when Prisma's engine download closed the TLS connection.
After merge, all three feature-branch release jobs restored the verified native bundles and passed SDK and packed consumer tests in 4m13s. Merged feature push