Skip to content

Skip release contract fixtures in SDK coverage - #2180

Merged
markstuart-oai merged 1 commit into
feat/codex-harnessfrom
codex/js-coverage-contract-fixtures
Nov 5, 2026
Merged

markstuart-oai merged 1 commit into
feat/codex-harnessfrom
codex/js-coverage-contract-fixtures

Conversation

@markstuart-oai

@markstuart-oai markstuart-oai commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

The SDK coverage job timed out in a fixture that checks TypeScript release declarations. The Node 22 and Node 24 jobs both passed all 97 release contract cases on the same commit. Coverage failure · Node 22 · Node 24

This change skips that fixture file in the coverage job. The ordinary test jobs still run every release contract case on both Node versions. Vitest still collects all 343 SDK package test files for coverage, and CI enforces the same thresholds.

Running the 97 release contract cases alone took 4m33s and covered zero lines, branches, functions, or statements across 434 SDK source files.

On GitHub, the coverage step took 1m40s, down from 3m15s on #2177's green retry. The coverage job took 3m08s, down from 4m29s. All four thresholds passed. Both Node versions passed all 97 release contract cases and the Prisma memory tests. CI on this change · Previous green coverage job

The full workflow finished in 5m57s versus 9m24s on #2177's first attempt. Node 22 finished last on both runs. It started 65 seconds earlier and ran 142 seconds faster on this run, accounting for the full-workflow difference.

The CI build and coverage commands passed locally. Vitest passed 9,444 tests, and the released SDK passed all four coverage thresholds. The full local wrapper stopped when Prisma's engine download closed the TLS connection.

After merge, all three feature-branch release jobs restored the verified native bundles and passed SDK and packed consumer tests in 4m13s. Merged feature push

@markstuart-oai
markstuart-oai requested a review from a team as a code owner November 5, 2026 10:52
@changeset-bot

changeset-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d8c819f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T10:53:03.865461Z d8c819f PR opened
🔒 Security Review ✅ Completed 2026-11-05T10:53:24.374249Z d8c819f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The exclusion applies only to the coverage invocation. Node 22 and 24.3.x still run the full suite including release-contract fixtures, while SDK source coverage selection and enforcement thresholds remain unchanged.

Reviewed commit d8c819f. Static review with an independent reviewer; no candidate code or tests were run. Hosted CI follow-up remains tracked separately.

@markstuart-oai
markstuart-oai merged commit b8a5130 into feat/codex-harness Nov 5, 2026
8 checks passed
@markstuart-oai
markstuart-oai deleted the codex/js-coverage-contract-fixtures branch November 5, 2026 10:59
@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Hosted CI complete at d8c819f: all eight checks passed, including coverage, both Node test versions and all three native package platforms. The PR is merged; closing CI follow-up. No candidate code/tests or CI reruns were executed locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants