Skip to content

fix(setup): fall back when broker auth is busy - #715

Open
ALV0612 wants to merge 1 commit into
openai:mainfrom
ALV0612:fix/issue-342-fallback-on-busy-auth-check
Open

fix(setup): fall back when broker auth is busy#715
ALV0612 wants to merge 1 commit into
openai:mainfrom
ALV0612:fix/issue-342-fallback-on-busy-auth-check

Conversation

@ALV0612

@ALV0612 ALV0612 commented Sep 2, 2026

Copy link
Copy Markdown

Summary

  • preserve broker RPC errors so auth setup can classify transport failures
  • retry auth reads through one direct app-server when a shared broker is busy or stale
  • avoid retrying genuine RPC failures and preserve direct failure diagnostics
  • add deterministic busy/stale/non-retryable/cleanup coverage

Verification

  • focused auth fallback tests: 5/5 pass
  • full suite: 96/96 pass
  • build and version checks pass
  • OpenSpec strict validation and git diff --check pass

Fixes #342

@ALV0612
ALV0612 requested a review from a team September 2, 2026 10:07
@ALV0612

ALV0612 commented Sep 2, 2026

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 133178d560

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] /codex:setup reports loggedIn:false when shared broker is busy; getCodexAuthStatus missing direct-fallback

1 participant