Skip to content

fix(review): preserve adversarial focus text - #714

Open
ALV0612 wants to merge 2 commits into
openai:mainfrom
ALV0612:fix/issue-333-preserve-adversarial-focus-text
Open

fix(review): preserve adversarial focus text#714
ALV0612 wants to merge 2 commits into
openai:mainfrom
ALV0612:fix/issue-333-preserve-adversarial-focus-text

Conversation

@ALV0612

@ALV0612 ALV0612 commented Sep 2, 2026

Copy link
Copy Markdown

Summary

  • keep a single adversarial-review focus argument opaque instead of re-tokenizing prose as CLI options
  • parse only supported option prefixes for legacy raw wrapper strings
  • stop option parsing after focus begins, including literal --model and -m examples
  • add end-to-end fake app-server regression coverage

Verification

  • focused regression: pass
  • full suite: 92/92 pass
  • build and version checks pass
  • OpenSpec strict validation and git diff --check pass

Fixes #333

@ALV0612
ALV0612 requested a review from a team September 2, 2026 10:06

@sylvesterkaczmarek sylvesterkaczmarek left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flag leak is fixed, but the focus still isn't opaque in the single-argv path. splitRawArgumentString reparses the whole value and then the suffix is rebuilt with join(" "), which strips quotes/backslashes and normalises whitespace. For example a focus containing a Windows path like C:\temp\foo loses the backslashes before it reaches the review prompt. Once the first positional starts, can we preserve the original raw suffix verbatim instead of reconstructing it from tokens?

@ALV0612

ALV0612 commented Sep 2, 2026

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 6efffaa78f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Focus text in adversarial-review is re-tokenized; --FLAG VALUE substrings leak into CLI args

2 participants