fix(workspace): do not hardcode the workspace cookie domain - #589
Open
thereisnotime wants to merge 2 commits into
Open
fix(workspace): do not hardcode the workspace cookie domain#589thereisnotime wants to merge 2 commits into
thereisnotime wants to merge 2 commits into
Conversation
setWorkspaceCookie always set domain=.openagents.org. A browser drops a cookie whose Domain attribute the current host is not a member of, so on any self-hosted deployment neither oa_workspace nor oa_has_workspace was ever stored. It failed silently, since setting document.cookie reports nothing. Keeps the shared cookie on openagents.org and its subdomains, and omits the attribute elsewhere so the browser scopes it to the current host.
|
@thereisnotime is attempting to deploy a commit to the Raphael's projects Team on Vercel. A member of the Team first needs to authorize it. |
Fork PRs don't receive org secrets from GitHub Actions, so E2E_WS_TOKEN is always empty for external contributors. The test was fataling immediately rather than skipping, blocking PRs that touch workspace/. Adding an if condition on the job so fork PRs get a clean skip instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`setWorkspaceCookie` always sets the domain attribute to `.openagents.org`:
```ts
const shared = `path=/;max-age=${maxAge};secure;samesite=lax;domain=.openagents.org`;
```
A browser drops a cookie whose `Domain` attribute the current host is not a member of, so on any self-hosted deployment neither `oa_workspace` nor `oa_has_workspace` is ever stored. It fails silently: assigning to `document.cookie` reports nothing back.
The change keeps the shared cookie on `openagents.org` and its subdomains, and omits the attribute elsewhere so the browser scopes it to the current host.
Low impact today, since nothing in the repo reads either cookie yet, but it is wrong wherever the value is eventually consumed.
Also folded in a CI fix: the `agent-smoke` job was fataling on fork PRs because `E2E_WS_TOKEN` is not passed to fork workflows by GitHub Actions. Added an `if` condition so the job skips cleanly instead of failing.