Skip to content

Fix linux binary #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-kuhn wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix linux binary #1

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f8761c
Fix linux binary
m-kuhn Jan 5, 2025
68cd70b
Export a dummy vcpkg root to make binary happy
m-kuhn Jan 5, 2025
375aad7
Update hook.py
m-kuhn Jan 5, 2025
21770eb
Update vcpkg_precommit/hook.py
m-kuhn Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions vcpkg_precommit/hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import argparse
import os
import platform
import subprocess
import tempfile
from pathlib import Path
from typing import Optional, Sequence
from urllib.request import urlretrieve
Expand All @@ -13,8 +15,8 @@ def get_vcpkg_binary() -> Path:

binary_map = {
("windows", "amd64"): ("vcpkg.exe", "vcpkg-windows-x64.exe"),
("linux", "x86_64"): ("vcpkg", "vcpkg-linux"),
("darwin", "arm64"): ("vcpkg", "vcpkg-macos-arm64"),
("linux", "x86_64"): ("vcpkg", "vcpkg-glibc"),
("darwin", "arm64"): ("vcpkg", "vcpkg-macos"),
("darwin", "x86_64"): ("vcpkg", "vcpkg-macos"),
}

Expand All @@ -39,6 +41,7 @@ def get_vcpkg_binary() -> Path:

def format_manifest_vcpkg_json(filename: str, vcpkg_binary: Path) -> bool:
"""Format a single vcpkg.json file."""
os.environ["VCPKG_ROOT"] = tempfile.TemporaryDirectory()
Comment thread
m-kuhn marked this conversation as resolved.
Outdated
result = subprocess.run(
[str(vcpkg_binary), "format-manifest", "--x-wait-for-lock", filename],
capture_output=True,
Expand Down