Skip to content

Fix: ETW span ownership lifetime#4070

Open
fmutlu68 wants to merge 7 commits into
open-telemetry:mainfrom
fmutlu68:fix-etw-span-ownership
Open

Fix: ETW span ownership lifetime#4070
fmutlu68 wants to merge 7 commits into
open-telemetry:mainfrom
fmutlu68:fix-etw-span-ownership

Conversation

@fmutlu68
Copy link
Copy Markdown

@fmutlu68 fmutlu68 commented May 8, 2026

Fixes #3849

Changes

  • Hold shared ownership of the ETW tracer in Span to prevent dangling references
  • Update span creation to pass shared ownership
  • Testing: ./ci/do_ci.sh cmake.c++17.test

@fmutlu68 fmutlu68 changed the title Fix ETW span ownership lifetime Fix: ETW span ownership lifetime May 10, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.10%. Comparing base (3057616) to head (1f76b52).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4070   +/-   ##
=======================================
  Coverage   82.10%   82.10%           
=======================================
  Files         385      385           
  Lines       15989    15989           
=======================================
  Hits        13126    13126           
  Misses       2863     2863           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fmutlu68
Copy link
Copy Markdown
Author

Could you please have a look here ? also @ThomsonTan It passes all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ETW Exporter: Crash When Ending ETW Exporter Span

2 participants