Skip to content

Fix typo in rtmdet_ins_head.py#12436

Open
andrei-anikin wants to merge 1 commit intoopen-mmlab:mainfrom
andrei-anikin:patch-1
Open

Fix typo in rtmdet_ins_head.py#12436
andrei-anikin wants to merge 1 commit intoopen-mmlab:mainfrom
andrei-anikin:patch-1

Conversation

@andrei-anikin
Copy link
Copy Markdown

Motivation

rtmdet_ins_head has a typo, that leads to to a bug - reg_convs layer is initialised incorrectly

Modification

self.reg_convs inside rtmdet_ins_head.py now initialised correctly

BC-breaking (Optional)

RTMDetInsSepBNHead will not be initialized correctly with previously trained weights with a bug

Use cases (Optional)

I needed that because I initially trained a bbox-only model and wanted to start a second training with only segmentation head not freezed, but it wasn't possible because of this issue.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants