Skip to content

Refactor label handling in cross_entropy_loss.py#12431

Open
shyhyawJou wants to merge 2 commits intoopen-mmlab:mainfrom
shyhyawJou:my
Open

Refactor label handling in cross_entropy_loss.py#12431
shyhyawJou wants to merge 2 commits intoopen-mmlab:mainfrom
shyhyawJou:my

Conversation

@shyhyawJou
Copy link
Copy Markdown

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

  • When I use RTMDet and train with cross entropy loss, it will occur an error as shown below:
mmdet/models/losses/cross_entropy_loss.py", line 120, in binary_cross_entropy
    if pred.dim() != label.dim():
AttributeError: 'tuple' object has no attribute 'dim'
  • my config about loss_cls:
loss_cls=dict(
    _delete_=True,
    type='CrossEntropyLoss',  
    use_sigmoid=True,
    loss_weight=1.),

Modification

  • By default, the loss_cls label in RTMDet consists of two components: a categorical label and a quality score (quality label). This PR modifies the label handling to specifically target the categorical part.
    My modifiacation is shown below:
# label[0] are categorical labels of images
if isinstance(label, tuple) and len(label) > 1:
    label = label[0]

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

  • No !

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

  • No new feature !

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 22, 2026

CLA assistant check
All committers have signed the CLA.

Removed unnecessary blank lines in the cross_entropy_loss.py file.
@shyhyawJou
Copy link
Copy Markdown
Author

@ZwwWayne
Hi, I failed to pass CircleCI, I guess the python version of CircleCI is too old (python3.7).
What can I do for passing the checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants