Skip to content

refactor: remove embedded mode methods from router classes #28063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ShaileshParmar11 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor: remove embedded mode methods from router classes #28063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...ources/ui/src/pages/GlobalSettingPage/GlobalSettingCategory/GlobalSettingCategoryPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,18 +106,15 @@ const GlobalSettingCategoryPage = () => {

break;
default:
if (
connectionsRouterClassBase.isEmbeddedMode() &&
category === GlobalSettingsMenuCategory.SERVICES
) {
if (isEmbedded && category === GlobalSettingsMenuCategory.SERVICES) {
navigate(connectionsRouterClassBase.getSettingsServicesPath(option));
} else {
navigate(getSettingPath(category, option));
}

break;
}
}, []);
}, [isEmbedded, navigate]);

return (
<PageLayoutV1 pageTitle={t('label.setting-plural')}>
Expand Down
12 changes: 0 additions & 12 deletions openmetadata-ui/src/main/resources/ui/src/utils/ConnectionsRouterClassBase.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,18 +59,6 @@ describe('ConnectionsRouterClassBase', () => {
router = new ConnectionsRouterClassBase();
});

describe('embeddedMode', () => {
it('setEmbeddedMode should be a no-op', () => {
router.setEmbeddedMode(true);

expect(router.isEmbeddedMode()).toBe(false);
});

it('isEmbeddedMode should always return false', () => {
expect(router.isEmbeddedMode()).toBe(false);
});
});

describe('getSettingsServicesPath', () => {
it('should return the generic settings services path when no category given', () => {
expect(router.getSettingsServicesPath()).toBe('/settings/services');
Expand Down
8 changes: 0 additions & 8 deletions openmetadata-ui/src/main/resources/ui/src/utils/ConnectionsRouterClassBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,6 @@ import {
import { getServiceRouteFromServiceType } from './ServiceUtils';

class ConnectionsRouterClassBase {
public setEmbeddedMode(_flag: boolean): void {
// no-op in base; overridden in Collate
}

public isEmbeddedMode(): boolean {
return false;
}

public getSettingsServicesPath(serviceCategory?: string): string {
if (serviceCategory) {
return getSettingPath(
Expand Down
12 changes: 0 additions & 12 deletions openmetadata-ui/src/main/resources/ui/src/utils/ObservabilityRouterClassBase.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,18 +65,6 @@ describe('ObservabilityRouterClassBase', () => {
router = new ObservabilityRouterClassBase();
});

describe('embeddedMode', () => {
it('setEmbeddedMode should be a no-op', () => {
router.setEmbeddedMode(true);

expect(router.isEmbeddedMode()).toBe(false);
});

it('isEmbeddedMode should always return false', () => {
expect(router.isEmbeddedMode()).toBe(false);
});
});

describe('getDataQualityPagePath', () => {
it('should return base path without tab', () => {
expect(router.getDataQualityPagePath()).toBe('/data-quality');
Expand Down
8 changes: 0 additions & 8 deletions openmetadata-ui/src/main/resources/ui/src/utils/ObservabilityRouterClassBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@ import {
} from './RouterUtils';

class ObservabilityRouterClassBase {
public setEmbeddedMode(_flag: boolean): void {
// no-op in base; overridden in Collate
}

public isEmbeddedMode(): boolean {
return false;
}

public getDataQualityPagePath(
tab?: DataQualityPageTabs,
subTab?: string
Expand Down
Loading