Repository navigation
Add resource group bypassing for GUC rollback - #438
Merged
Smyatkin-Maxim merged 1 commit intoOct 8, 2026
Merged
Conversation
GP guc changes are not transactionally safe on QE side and there is a hack to restore previous setting with the next BE request. This hack, however, fails to bypass RG controls because debug_query_string is NULL. This commit forses RG bypass and adds a simple test for this case.
leborchuk
approved these changes
Oct 7, 2026
leborchuk
left a comment
leborchuk
left a comment
Contributor
There was a problem hiding this comment.
LGTM, clearly it's the main issue.
By the way, in cloudberry we have the same issue since the PR with bug apache/cloudberry@73cab2c is in cloudberry too.
You also could look at arenadata/greengage@dc3b23a
There are a lot of code not relevant our issue here, but look at
MemoryContext oldcontext = CurrentMemoryContext;
...
/*
* this is a top-level catch block and we are responsible for
* restoring the right memory context.
*/
MemoryContextSwitchTo(oldcontext);
}
PG_END_TRY();
Maybe it also worth to restore original Memory Context
Alena0704
approved these changes
Oct 7, 2026
Smyatkin-Maxim
added a commit
that referenced
this pull request
Oct 8, 2026
GP guc changes are not transactionally safe on QE side and there is a hack to restore previous setting with the next BE request. This hack, however, fails to bypass RG controls because debug_query_string is NULL. This commit forses RG bypass and adds a simple test for this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GP guc changes are not transactionally safe on QE side and there is a hack to restore previous setting with the next BE request. This hack, however, fails to bypass RG controls because debug_query_string is NULL. This commit forces RG bypass and adds a simple test for this case.