gp_stats_collector: opt-in EXPLAIN (FORMAT JSON) plans, extension 1.2 - #424
Open
Sanikadze wants to merge 12 commits into
Open
gp_stats_collector: opt-in EXPLAIN (FORMAT JSON) plans, extension 1.2#424Sanikadze wants to merge 12 commits into
Sanikadze wants to merge 12 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Consumers that draw the plan as a tree (yagpcc's Grafana panel via PEV2) need it as data. The text plan does not parse reliably: structure is in indentation, Greenplum adds its own annotations (
Gather Motion 2:1 (slice1; segments: 2),Rows out: ..., ORCA cost lines), and PEV2 fromText drops Motion nodes. EXPLAIN (FORMAT JSON) comes from the same tree walk and is stable across minor versions.Text plans are unchanged and always collected. plan_id is still the hash of the normalized text plan.
Extension 1.1 -> 1.2
gpsc.__log is built positionally from log_tbl_desc, so the layout changes.
gp_stats_collector--1.1--1.2.sql:ALTER TABLE ... ADD COLUMNx2, gpsc.log view recreated.ALTER EXTENSION gp_stats_collector UPDATE, and skips table logging until then. UDS logging is unaffected.Compatibility