Skip to content

fix: add additional tags for better filtering options - #339

Merged
toddbaert merged 1 commit into
mainfrom
fix/add_seperation_tags
Sep 11, 2025
Merged

toddbaert merged 1 commit into
mainfrom
fix/add_seperation_tags

Conversation

@aepfli

@aepfli aepfli commented Sep 10, 2025

Copy link
Copy Markdown
Member

it is hard not to diverge between a cached and a stable response - so i added an additional tag to separate both cases

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
aepfli requested a review from a team as a code owner September 10, 2025 18:26

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @aepfli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the test specification by adding more precise Gherkin tags to scenarios related to flag evaluation reason codes. This improvement aims to provide better filtering capabilities for test runs, making it easier to differentiate and manage tests for cached versus disabled flag responses.

Highlights

  • Gherkin Tagging Enhancement: Introduced specific Gherkin tags (@reason-codes-cached, @reason-codes-disabled) to scenarios in evaluation_v2.feature. This allows for more granular filtering and distinction between cached and disabled flag responses in test runs, addressing the challenge of differentiating between cached and stable responses.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds more specific Gherkin tags (@reason-codes-cached and @reason-codes-disabled) to improve test filtering and includes a whitespace cleanup. The new tags enhance the test suite's maintainability. I have one suggestion regarding formatting consistency in the feature file.

Comment thread specification/assets/gherkin/evaluation_v2.feature
@toddbaert
toddbaert merged commit 4542c3c into main Sep 11, 2025
5 checks passed
@toddbaert
toddbaert deleted the fix/add_seperation_tags branch September 11, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants