test: update spec requirement test names - #1454
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe server client test suite updates three requirement references to match revised requirement numbering. No exported or public entities change. ChangesServer client test references
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR only updates outdated requirement labels in server client tests without changing SDK behavior or assertions; no actionable merge-blocking risk remains after normal checks. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
|
Hi maintainers, just a quick follow-up on this PR. The spec requirement references have been updated and the focused tests are passing (45/45). Whenever you get a chance, I’d appreciate a review. Thanks! |
Summary
Updates outdated OpenFeature specification requirement references in
packages/server/test/client.spec.tsto match the revised specificationnumbering around the static-vs-dynamic context requirements.
Changes
Requirement 1.4.1→Requirement 1.4.1.1Requirement 1.4.3.1→Requirement 1.4.4.1Requirement 1.4.2, 1.4.3→Requirement 1.4.3No SDK implementation behavior or test assertions were changed.
Verification
Focused server client test:
npm exec jest -- --selectProjects=server --runInBand packages/server/test/client.spec.tsResult:
Also verified with
git diff --check.