Prototest manual input USA#68
Merged
Merged
Conversation
…on/technology-data into issue_59_prototest_manual_input
…on/technology-data into issue_59_prototest_manual_input
for more information, see https://pre-commit.ci
euronion
self-requested a review
October 28, 2025 10:26
…on/technology-data into issue_59_prototest_manual_input
…on/technology-data into issue_59_prototest_manual_input
Member
Author
for more information, see https://pre-commit.ci
…open-energy-transition/technology-data into issue_59_prototest_manual_input
…on/technology-data into issue_59_prototest_manual_input
euronion
requested changes
Jan 15, 2026
euronion
left a comment
euronion
left a comment
Member
There was a problem hiding this comment.
I don't understand a few things, but most things look good!
Comment on lines
+3077
to
+3079
| "units": "dimensionless", | ||
| "carrier": "hydrogen / fischer_tropsch", | ||
| "heating_value": "lower_heating_value", |
Member
There was a problem hiding this comment.
Are you doing some unit conversion here, or is this done automatically by pint?
In the original data this is MWh_hydrogen/MWh_fischer_tropsch. Both should be LHV, i.e. heating_value should be LHV/LHV if I remember my implementation correctly.
Co-authored-by: Johannes HAMPP <42553970+euronion@users.noreply.github.com>
…usa.py Co-authored-by: Johannes HAMPP <42553970+euronion@users.noreply.github.com>
…usa.py Co-authored-by: Johannes HAMPP <42553970+euronion@users.noreply.github.com>
…usa.py Co-authored-by: Johannes HAMPP <42553970+euronion@users.noreply.github.com>
for more information, see https://pre-commit.ci
Co-authored-by: Johannes HAMPP <42553970+euronion@users.noreply.github.com>
Co-authored-by: Johannes HAMPP <42553970+euronion@users.noreply.github.com>
… into issue_59_prototest_manual_input
for more information, see https://pre-commit.ci
…open-energy-transition/technology-data into issue_59_prototest_manual_input
for more information, see https://pre-commit.ci
…open-energy-transition/technology-data into issue_59_prototest_manual_input
euronion
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #59.
Changes proposed in this Pull Request
Checklist
doc.environment.yaml(if applicable).doc/release_notes.rstof the upcoming release is included.