Skip to content

Keep model architectures list expanded when navigating back #6881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andersendsa wants to merge 7 commits into
base: develop
Choose a base branch
from
+75 −3
Open

Keep model architectures list expanded when navigating back #6881

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f393c0e
fix: keep model architectures list expanded when navigating back
andersendsa Jun 20, 2026
81cd321
Merge branch 'develop' into keep_architecture
andersendsa Jun 20, 2026
2d1bb76
adding tests
andersendsa Jun 22, 2026
6556c63
adding test
andersendsa Jun 23, 2026
63fb062
avoiding resets when navigate to AdvancedSettings
andersendsa Jun 23, 2026
d27baed
reverting user effect
andersendsa Jun 23, 2026
4de41f0
reverting changes
andersendsa Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...atures/models/train-model/model-architectures-list/model-architectures-list.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,20 @@ import { getRecommendedArchitectures } from './utils';
const SHOW_MORE_THRESHOLD = 4;

export const ModelArchitecturesList = () => {
const [showMore, setShowMore] = useState<boolean>(false);
const { modelArchitectures, selectedModelArchitectureId, onSelectModelArchitectureId } = useTrainModelState();

const recommendedArchitectures = getRecommendedArchitectures(modelArchitectures);
const collapsedArchitectures = recommendedArchitectures.slice(0, SHOW_MORE_THRESHOLD);
const canToggleArchitecturesList = modelArchitectures.length > SHOW_MORE_THRESHOLD;

const [showMore, setShowMore] = useState<boolean>(() => {
if (selectedModelArchitectureId !== null) {
const isSelectedInCollapsed = collapsedArchitectures.some((arch) => arch.id === selectedModelArchitectureId);
return !isSelectedInCollapsed;
}
Comment on lines +22 to +28
return false;
});
Comment on lines +22 to +30

return (
<Flex direction={'column'} minHeight={0} gap={'size-300'}>
{showMore ? (
Expand Down