Skip to content
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,22 @@ import { getRecommendedArchitectures } from './utils';
const SHOW_MORE_THRESHOLD = 4;

export const ModelArchitecturesList = () => {
const [showMore, setShowMore] = useState<boolean>(false);
const { modelArchitectures, selectedModelArchitectureId, onSelectModelArchitectureId } = useTrainModelState();

const recommendedArchitectures = getRecommendedArchitectures(modelArchitectures);
const collapsedArchitectures = recommendedArchitectures.slice(0, SHOW_MORE_THRESHOLD);
const canToggleArchitecturesList = modelArchitectures.length > SHOW_MORE_THRESHOLD;

const [showMore, setShowMore] = useState<boolean>(() => {
if (selectedModelArchitectureId !== null) {
const isSelectedInCollapsed = collapsedArchitectures.some(
(arch) => arch.id === selectedModelArchitectureId
);
return !isSelectedInCollapsed;
}
Comment on lines +22 to +28
return false;
});
Comment on lines +22 to +30

return (
<Flex direction={'column'} minHeight={0} gap={'size-300'}>
{showMore ? (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { render } from 'test-utils/render';
import { ModelArchitecturesList } from './model-architectures-list.component';

const mockOnSelectModelArchitectureId = vi.hoisted(() => vi.fn());
const mockSelectedModelArchitectureId = vi.hoisted(() => ({ value: null as string | null }));

const mockModelArchitectures = [
getMockedModelArchitecture({ id: 'arch-1', name: 'Alpha Model' }),
Expand All @@ -20,14 +21,15 @@ const mockModelArchitectures = [
vi.mock('../train-model-provider.component', () => ({
useTrainModelState: () => ({
modelArchitectures: mockModelArchitectures,
selectedModelArchitectureId: null,
selectedModelArchitectureId: mockSelectedModelArchitectureId.value,
onSelectModelArchitectureId: mockOnSelectModelArchitectureId,
}),
}));

describe('ModelArchitecturesList', () => {
beforeEach(() => {
mockOnSelectModelArchitectureId.mockReset();
mockSelectedModelArchitectureId.value = null;
});

it('does not render the sort control in the default (recommended) view', () => {
Expand All @@ -53,4 +55,12 @@ describe('ModelArchitecturesList', () => {
fireEvent.click(screen.getByRole('button', { name: 'Show less' }));
expect(screen.queryByRole('button', { name: /Sort Models by:/i })).not.toBeInTheDocument();
});

it('renders expanded list by default if a non-default architecture is already selected', () => {
mockSelectedModelArchitectureId.value = mockModelArchitectures[mockModelArchitectures.length - 1].id;
render(<ModelArchitecturesList />);

expect(screen.getByRole('button', { name: 'Show less' })).toBeVisible();
expect(screen.getByRole('button', { name: /Sort Models by:/i })).toBeVisible();
});
Comment on lines +59 to +65
});
48 changes: 47 additions & 1 deletion application/ui/tests/models/model-training.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,23 @@ import { expect, http, test } from '../fixtures';
import { MOCKED_MODEL_TRAINING_CONFIGURATION, MOCKED_TRAINING_CONFIGURATION } from './mocks';

const mockedModelArchitectures = [
getMockedModelArchitecture({ id: 'Object_Detection_SSD', name: 'Object_Detection_SSD' }),
getMockedModelArchitecture({
id: 'Object_Detection_SSD',
name: 'Object_Detection_SSD',
performanceCategory: 'balance',
}),
getMockedModelArchitecture({
id: 'Custom_Object_Detection_Gen3_ATSS',
name: 'Custom_Object_Detection_Gen3_ATSS',
performanceCategory: 'speed',
}),
getMockedModelArchitecture({ id: 'arch-3', name: 'Gamma Model', performanceCategory: 'accuracy' }),
getMockedModelArchitecture({ id: 'arch-4', name: 'Delta Model', performanceCategory: undefined }),
getMockedModelArchitecture({ id: 'arch-5', name: 'Epsilon Model', performanceCategory: undefined }),
getMockedModelArchitecture({
id: 'Object_Detection_YOLOX_X',
name: 'Object_Detection_YOLOX_X',
performanceCategory: undefined,
}),
];

Expand Down Expand Up @@ -265,6 +278,39 @@ test.describe('Model training flow', () => {
);
});

test('Keeps model architectures list expanded when navigating back from advanced settings if non-default model is selected', async ({
network,
modelsPage,
page,
}) => {
setupNetworkMocks(network);

await modelsPage.goto();
await modelsPage.openTrainModelDialog();

await test.step('Expand architectures list', async () => {
await page.getByRole('button', { name: 'Show more' }).click();
});

await test.step('Select a non-default model architecture', async () => {
await modelsPage.selectModelArchitecture('Object_Detection_YOLOX_X');
});

await test.step('Open advanced settings', async () => {
await modelsPage.openAdvancedSettings();
await expect(page.getByLabel('Advanced settings tabs').getByText('Data management')).toBeVisible();
});

await test.step('Navigate back', async () => {
await page.getByRole('button', { name: 'Back' }).click();
});

await test.step('Verify that the list is still expanded', async () => {
await expect(page.getByRole('button', { name: 'Show less' })).toBeVisible();
await expect(page.getByRole('button', { name: /Sort Models by:/i })).toBeVisible();
});
});

test('Advanced model training flow with training from scratch', async ({ network, modelsPage }) => {
const state = setupNetworkMocks(network);

Expand Down
Loading