Repository navigation
CI: run on main and test against Node 18 and 26 - #438
Merged
Merged
Conversation
CI only triggered for the devel branch, but PRs are merged into main, so they currently get no CI. Also run the job on Node 26 alongside Node 18, since online-go#436 only reproduced on newer Node. The node_modules cache key now includes the Node version so native modules aren't shared across versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@anoek this is a proposal. Merge it or close it as you see fit.
Changes
mainas well asdevel. The workflow only triggers on pushes and PRs todevel, but recent PRs (Fix checkAllowedRank to use the challenger's rank #434, Update dependencies to resolve Dependabot security alerts #435, Fix "Invalid URL" config error with jsonschema 1.5 on Node 26 #437) targetmain, so they get no CI at all.node_modulescache key. Otherwise the two matrix jobs would share a cache, and native modules (bufferutil,utf-8-validate) built for one Node version could be reused under another.No other steps changed.
Verification
I ran the workflow's steps locally on Node 26 in a clean checkout (yarn install, eslint, prettier check, minified webpack build, jest):
main: all pass (16 tests)This PR should trigger CI on itself, since
pull_requestworkflows use the PR's version of the workflow file. If you merge this before #437, rebasing #437 will get it a CI run on both Node versions.🤖 Generated with Claude Code