Skip to content

fix(service): only log TLS session keys when SSLKEYLOGFILE is set #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gab-arrobo merged 2 commits into from
Oct 7, 2026
+6 −1
Merged

fix(service): only log TLS session keys when SSLKEYLOGFILE is set #357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6abfd35
fix(service): only log TLS session keys when SSLKEYLOGFILE is set
midwell Oct 5, 2026
daf762e
fix(service): warn about TLS key logging only when keys are written
midwell Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion service/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ func (nssf *NSSF) Start() {
os.Exit(0)
}()

sslLog := filepath.Dir(factory.NssfConfig.CfgLocation) + "/sslkey.log"
// TLS key logging is a debugging aid: off unless the operator sets SSLKEYLOGFILE.
sslLog := os.Getenv("SSLKEYLOGFILE")
server, err := http2_util.NewServer(addr, sslLog, router)

if server == nil {
Expand All @@ -144,6 +145,10 @@ func (nssf *NSSF) Start() {
case "http":
err = server.ListenAndServe()
case "https":
if server.TLSConfig != nil && server.TLSConfig.KeyLogWriter != nil {
logger.InitLog.Warnf("TLS key logging is enabled (SSLKEYLOGFILE=%s): SBI traffic is "+
"decryptable by anyone who can read this file", sslLog)
}
err = server.ListenAndServeTLS(self.PEM, self.Key)
default:
logger.InitLog.Fatalf("HTTP server setup failed: invalid server scheme %+v", serverScheme)
Expand Down
Loading