Repository navigation
Simplify control flow and use openapi model accessors - #358
Merged
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
🟢 Approval recommended
The refactoring preserves behavior and correctly uses the repository’s Go and OpenAPI APIs.
0 open findings
What changed in this PR
Simplifies AUSF control flow and adopts OpenAPI helpers/accessors without changing intended behavior.
Changes:
- Replaces direct model access with OpenAPI constructors and accessors.
- Simplifies branching, routing, error creation, and polling backoff.
- Modernizes random-byte and pointer creation.
| File | Description |
|---|---|
producer/ue_authentication.go |
Simplifies authentication flows and model handling. |
producer/callback.go |
Removes redundant callback branching. |
polling/nf_configuration.go |
Uses standard min and OpenAPI error helpers. |
factory/factory.go |
Uses OpenAPI error reporting. |
context/ausf_context_init.go |
Uses model setters for NF services. |
consumer/nf_management.go |
Simplifies OpenAPI error model extraction. |
consumer/nf_discovery.go |
Streamlines subscription creation logic. |
callback/router.go |
Uses HTTP constants and named route fields. |
ausf_test.go |
Modernizes pointer construction in test data. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cmaciocco
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.