[andybavier]

Summary

Add an optional image_list input to the reusable E2E workflow.

• When unset, callers retain the current behavior, including UPF building both bess and pfcp.
• When set, the supplied space-separated image list drives configuration overrides, Docker builds, registry pushes, and deployed-image verification.
• Add a fixture test for the UPF PFCP-only case: PFCP is overridden with localhost:5000/pfcp:testing, while BESS retains its released chart tag.

This enables omec-project/upf#1301 to select images from its PR diff without embedding UPF source-layout rules in the shared workflow.

Validation

• Parsed .github/workflows/e2e-test.yml with PyYAML.
• python3 -m unittest discover -s .github/tests -v (8 passed).
• git diff --check.

[gab-arrobo]

Changes look good to me. However, you also need to make changes to VERSION file to create a patch release

[Copilot]

🟡 Changes recommended

Address the shell-injection risk and inconsistent GNBSIM image configuration.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds optional image_list selection to the reusable E2E workflow while preserving default behavior, with PFCP-only fixture coverage.

Changes:

• Adds configurable image selection and fallback behavior.
• Applies selected images to configuration, builds, pushes, and verification.
• Adds PFCP-only override coverage.

File summaries

File	Summary
.github/workflows/e2e-test.yml	Adds image-list handling for E2E image configuration and deployment.
.github/tests/test_update_aether_files.py	Tests selective PFCP image overrides.

Review details

Suppressed comments (1)

.github/workflows/e2e-test.yml:42

• The new list is not used consistently for the gnbsim repository: the update step still configures localhost:5000/${IMAGE_NAME}:testing, while the build/push loop consumes IMAGE_LIST. Supplying any list other than the repo-derived name therefore builds one image but configures the test to use another (and the helper rejects combining --gnbsim-image with --image-list). Either reject image_list for GNBSIM or use a validated single selected image for its configuration override.

          IMAGE_LIST="${{ inputs.image_list }}"

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

Retain the development version suffix or handle the release separately to avoid an unintended release trigger.

Get a fresh assessment by requesting another Copilot review.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Lite