-
Notifications
You must be signed in to change notification settings - Fork 18
Use the the original PostgreSQL configuration file #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
82efa2d
3637a0e
35930b0
0879c9f
9ee77fa
9790b98
743d5f3
dcaa4eb
8151508
5b1c41a
bc2b2ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,7 @@ postgresql_server_auth: [] | |
| # Recursively reset the owner/group of the postgres datadir? | ||
| postgresql_server_chown_datadir: false | ||
|
|
||
| postgres_config_file_contents: '' | ||
| ###################################################################### | ||
| # Internal role variables, do not modify | ||
| ###################################################################### | ||
|
|
@@ -51,14 +52,19 @@ postgresql_dist_redhat: | |
| {{ | ||
| (postgresql_package_version | length > 0) | | ||
| ternary('-' + postgresql_package_version, '') | ||
| }} | ||
| }} | ||
|
|
||
| # Attributes are parsed and used to set facts at tasks/debian.yml. | ||
| # Debian variation, following the same principles of postgresql_dist_redhat | ||
| postgresql_dist_debian: | ||
| bindir: /usr/lib/postgresql/{{ postgresql_version }}/bin | ||
| confdir: /etc/postgresql/{{ postgresql_version }}/main | ||
| conf_postgresql_src: postgresql-conf-10-ubuntu.j2 | ||
| conf_postgresql_src: postgresql-conf.j2 | ||
| datadir: /var/lib/postgresql/{{ postgresql_version }}/main | ||
| basename: postgresql-{{ postgresql_version }} | ||
| service: postgresql | ||
|
|
||
| # conf_sample_file: sample configuration file, it should be copied during the installation by the installation package | ||
|
|
||
| # the following two variables are used to download link ofr the source to get the sample configuration file | ||
| # It will be used in case of the sample file is not find locally for any reason | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason not to have a hard fail in case Are you aware of any scenario where this file could legitimately be expected to be missing?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On our RHEL 9 test machine, there are 4 PostgreSQL versions have been installed (13, 14, 15, 16). Only version 16 folder has the sample file and the others do not have this file. I am not sure how these versions have been installed but I think the file should be there. I am not sure why it is missing. So, I have added the logic of downloading and extracting the file to account for similar cases.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting (and slightly concerning). Note all of the PSQL sample configuration file checks seem to be currently skipped in the Molecule tests on both Rocky Linux. I don't know if that's expected or indicates another issue.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It will check for the sample file if the original file does not exist and the configuration file has been edited before, i.e. in case of installing the same PostgreSQL version with a previous role version. |
||
Uh oh!
There was an error while loading. Please reload this page.