Repository navigation
Run the test suites on every pull request and push - #15205
Open
namespaceMarcello wants to merge 2 commits into
Open
namespaceMarcello wants to merge 2 commits into
namespaceMarcello wants to merge 2 commits into
Conversation
./test/all had no workflow here, so a change that broke a test in another area reached quattro unnoticed. This runs it in an Arch container that boots systemd and allows user namespaces, the way omarchy-iso runs its unit tests, so the tests of the root helpers run instead of skipping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
The companion checkouts follow their default branches, so the same commit here can be tested against different packaging and ISO files. The run's summary now lists the three commits it used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Nice, having A few non-blocking thoughts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./test/allhas no workflow in this repository, whileomarchy-isoandomarchy-pkgsrun their suites on every pull request. This adds one for the CLI and shell suites, shaped likeomarchy-iso'sunit-test.yml: an Arch container that boots systemd, the two companion checkouts next to the repo, and the suite run by an ordinary user with no sudo. It takes about fourteen minutes on a standard runner.The reason to want it is on
quattronow. On October 11 three commits each broke a test file in an area they did not touch:201de1c0(power-test.sh),cf473b5c(shell-shortcuts-test.sh) and14987189(toggle-input-device-test.sh). Focused tests passed each time and nothing ran the rest. #15157, #15156 and #15158 fix those three.Four details came out of running it rather than writing it, and each is explained where it sits in the file:
sysctlstep fourteen tests of the root helpers (lock, sudoers, factory reset, fingerprint, the Windows VM mounts) skip and the suite stays green: 5742 assertions instead of 5799./runis mountedexec:agent-account-test.shruns a file fromXDG_RUNTIME_DIRand fails withPermission deniedon Docker's defaultnoexectmpfs.newuidmapandnewgidmapwithout their file capabilities, soshadowis reinstalled.Trial runs on a fork, where a commit on top adds the trial branch to the
pushtrigger and nothing else:quattroat4c1b4cb3: 5 of 384 test files fail, 5799 assertions pass. The five are the three above,default-agent-test.sh(Expect mise unuse -y in the Grok migration tests #14493 and Match Grok migration fixtures to noninteractive cleanup #14660 are open for it) andpasswordless-grant-lifecycle-test.sh, which waits for apre_removeinomarchy-pkgs.34 tests skip in both. Most need a Wayland compositor; the others need Quickshell, Chromium, Kitty,
qmltestrunner, a user manager, a hiddev device or theen_US.UTF-8locale, none of which the container has.Two things to weigh before merging.
quattrois red today, so a run on any pull request based on it would fail the same way until those five files are fixed: this should land after them. Andsystem-sleep-ownership-migration-test.shpicks between two symlinks in an order that depends on a random suffix, so it can fail a run by chance until #14829 is in; it passed in every trial run here.#10181 also proposes a workflow for these suites. This one differs in booting systemd, allowing user namespaces and installing more of what the tests call, and it has been run.
Validation: the two runs linked above, and the same suite in a local container with systemd as PID 1, which gives the same counts file by file as the first of them.
Not checked: the
pull_requestandworkflow_dispatchtriggers, since the trial runs came from pushes; and the graphical acceptance suite, which this does not run.Written by Claude Code (AI assistant) on behalf of @namespaceMarcello, who directs this work.
🤖 Generated with Claude Code