Skip to content

docs(task-cycle): re-review the fix commit of an Important finding #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oluciano merged 1 commit into from
Oct 23, 2026
Merged

docs(task-cycle): re-review the fix commit of an Important finding #660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .agents/skills/nexjob-task-cycle/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ Follow this strict step order:
> *"Act as NexJob Reviewer following `.agents/method/modes/03-validation-mode.md`. Inspect `git diff develop`, verify StyleCop rules, XML documentation, CancellationToken propagation, .ConfigureAwait(false) usage, and ensure the 3N testing matrix has no weakened assertions. Return a structured PASS or FAIL verdict with specific file and line citations."*
- **Claude Code:** Invoke a background task/agent (e.g. `Task` tool) with the same prompt and mode instructions.
- **Benefit:** The heavy diff inspection and standards checklist run in an isolated context, returning only the final verdict and necessary fixes to the primary session without token bloat.
- **Re-check a fix:** after fixing an **Important** finding on a Deep-depth PR, run the reviewer again on the fix commit only (`git diff <commit-before-fix>`), with the same `REVIEW.md`. Answer `Fixed` in the thread only when that pass has no new Important finding. Nits and Standard/Quick PRs skip it. Stop after 3 rounds and question the approach.

4. **Step 4: Remediate Findings (Zero Toleration Gate):**
- If the subagent or tests report any finding (`FAIL`), fix the production code or tests immediately.
Expand Down
Loading