Skip to content

Fx lint broken - #16611

Merged
Jacobjeevan merged 1 commit into
developfrom
fix/lint
Jul 31, 2026
Merged

Fx lint broken#16611
Jacobjeevan merged 1 commit into
developfrom
fix/lint

Conversation

@NikhilA8606

@NikhilA8606 NikhilA8606 commented Jul 30, 2026

Copy link
Copy Markdown
Member

Proposed Changes

Fixes lint broken

image

Tagging: @ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate the bug or test the new feature.
  • Update product documentation.
  • Ensure that UI text is placed in I18n files.
  • Prepare a screenshot or demo video for the changelog entry and attach it to the issue.
  • Request peer reviews.
  • Complete QA on mobile devices.
  • Complete QA on desktop devices.
  • Add or update Playwright tests for related changes

Summary by CodeRabbit

  • Chores
    • Updated project checks to exclude files in the .opencode directory.

@NikhilA8606
NikhilA8606 requested review from a team and Copilot July 30, 2026 11:02
@github-actions

Copy link
Copy Markdown

⚠️ Merge Checklist Incomplete

Thank you for your contribution! To help us review your PR efficiently, please complete the merge checklist in your PR description.

Your PR will be reviewed once you have marked the appropriate checklist items.

To update the checklist:

  • Change - [ ] to - [x] for completed items
  • Only check items that are relevant to your PR
  • Leave items unchecked if they don't apply

The checklist helps ensure code quality, testing coverage, and documentation are properly addressed.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Changes

Knip configuration

Layer / File(s) Summary
Ignore .opencode files
knip.json
The Knip ignore list now excludes the .opencode/** directory tree.

Suggested reviewers: amjithtitus09, jacobjeevan

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing the required issue reference and a clear bullet list of proposed changes from the template. Add a Fixes #issue_number line and summarize the concrete changes in 1-2 bullets, while keeping the tagging and checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is related to the change, but it is vague and does not clearly describe the specific lint-ignore update.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lint

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🎭 Playwright Test Results

Status: ⏭️ Skipped

No test-related files were changed in this PR.

Tests are skipped when changes don't affect:

  • tests/**
  • src/**
  • package.json
  • playwright.config.ts

Run: #10496

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a broken lint/check by updating Knip’s configuration to ignore files under the .opencode directory, preventing Knip from analyzing generated/auxiliary content that should not be part of the project’s static analysis surface.

Changes:

  • Added a Knip ignore glob for .opencode/** to exclude that directory from Knip checks.

@amjithtitus09 amjithtitus09 added reviewed reviewed by a core member needs peer review and removed needs review labels Jul 31, 2026
@Jacobjeevan
Jacobjeevan merged commit 7f94541 into develop Jul 31, 2026
43 of 46 checks passed
@Jacobjeevan
Jacobjeevan deleted the fix/lint branch July 31, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed reviewed by a core member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants