fix: use consistent 'Log in' terminology instead of 'Sign in' - #16598
fix: use consistent 'Log in' terminology instead of 'Sign in'#16598Jayant-Sharma-Dev wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
WalkthroughChangesLogin terminology localization
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryUpdates the public login terminology from “Sign in” to “Log in.”
Confidence Score: 4/5The PR should not merge until the unintended direct modification to the Crowdin-managed Malayalam catalog is reverted. The attempted response to the previous review thread removes an established Malayalam translation rather than leaving the non-English locale file unchanged for Crowdin. Files Needing Attention: public/locale/ml.json
|
| Filename | Overview |
|---|---|
| public/locale/en.json | Adds the English log_in label and removes the superseded sign_in key. |
| public/locale/ml.json | Still directly modifies the Crowdin-managed Malayalam catalog by deleting a pre-existing translation. |
| src/components/Common/LoginHeader.tsx | Changes the public login button to use the new log_in translation key. |
Reviews (3): Last reviewed commit: "fix: use consistent 'Log in' terminology..." | Re-trigger Greptile
9688a68 to
ed0a6d5
Compare
rithviknishad
left a comment
There was a problem hiding this comment.
remove the "sign_in" key from translations after confirming it's not used elsewhere?
ed0a6d5 to
911255c
Compare
Checked ... |
| "show_patient_presets": "രോഗിയുടെ പ്രീസെറ്റുകൾ കാണിക്കുക", | ||
| "show_unread_notifications": "വായിക്കാത്തത് കാണിക്കുക", | ||
| "sign_in": "സൈൻ ഇൻ", | ||
| "sign_out": "ലോഗ് ഔട്ട് ചെയ്യുക/പുറത്തിറങ്ങുക", |
There was a problem hiding this comment.
Deletes Crowdin-managed translation
When this branch is merged or synchronized with Crowdin, this deletion removes the pre-existing Malayalam sign_in translation instead of leaving the non-English catalog unchanged, causing the established translation to be lost and the direct edit to conflict with the repository's Crowdin-managed workflow.
Context Used: CLAUDE.md (source)
There was a problem hiding this comment.
@rithviknishad Sir so shall I again add sign_in in ml.json?
|
@NikhilA8606 Any changes ? |
nihal467
left a comment
There was a problem hiding this comment.
the page is being fully redesigned, so the issue is not relevant anymore
Proposed Changes
Fixes #16584
log_intranslation key inen.json(rather than modifying the existingsign_inkey, which is still used elsewhere in the app for other strings).log_inkey toml.json(Malayalam) for consistency. Other locale files (hi, ta, mr, kn) were left untouched happy to add those too if needed, wasn't confident enough in the translations to guess.Before:

After:

Tagging: @ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit