Skip to content

fix: use consistent 'Log in' terminology instead of 'Sign in' - #16598

Closed
Jayant-Sharma-Dev wants to merge 1 commit into
ohcnetwork:developfrom
Jayant-Sharma-Dev:fix/sign-in-log-in-terminology
Closed

fix: use consistent 'Log in' terminology instead of 'Sign in'#16598
Jayant-Sharma-Dev wants to merge 1 commit into
ohcnetwork:developfrom
Jayant-Sharma-Dev:fix/sign-in-log-in-terminology

Conversation

@Jayant-Sharma-Dev

@Jayant-Sharma-Dev Jayant-Sharma-Dev commented Jul 24, 2026

Copy link
Copy Markdown

Proposed Changes

Fixes #16584

  • Updated the public-facing "Sign in" button to "Log in" for consistent terminology across the authentication flow, matching "Log in as Staff" / "Log in as Patient" already used on the auth/login page.
  • Added a new log_in translation key in en.json (rather than modifying the existing sign_in key, which is still used elsewhere in the app for other strings).
  • Also added the log_in key to ml.json (Malayalam) for consistency. Other locale files (hi, ta, mr, kn) were left untouched happy to add those too if needed, wasn't confident enough in the translations to guess.

Before:
image

After:
image
Tagging: @ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate the bug or test the new feature.
  • Update product documentation.
  • Ensure that UI text is placed in I18n files.
  • Prepare a screenshot or demo video for the changelog entry and attach it to the issue.
  • Request peer reviews.
  • Complete QA on mobile devices.
  • Complete QA on desktop devices.
  • Add or update Playwright tests for related changes

Summary by CodeRabbit

  • Bug Fixes
    • Updated the logged-out login button to use the correct localized label.
  • Localization
    • Added the English “Log in” translation and aligned the related login text key to improve consistency across languages.

@Jayant-Sharma-Dev
Jayant-Sharma-Dev requested review from a team and Copilot July 24, 2026 17:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5535ce9c-c849-43e6-855c-4e9614726e70

📥 Commits

Reviewing files that changed from the base of the PR and between ed0a6d5 and 911255c.

📒 Files selected for processing (3)
  • public/locale/en.json
  • public/locale/ml.json
  • src/components/Common/LoginHeader.tsx
💤 Files with no reviewable changes (1)
  • public/locale/ml.json

Walkthrough

Changes

Login terminology localization

Layer / File(s) Summary
Localized login label
public/locale/en.json, public/locale/ml.json, src/components/Common/LoginHeader.tsx
The logged-out login button now uses the log_in translation key, English defines it as “Log in,” and Malayalam removes the obsolete sign_in key.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: replacing "Sign in" with "Log in" for consistency.
Description check ✅ Passed The description follows the template and includes the required proposed changes, issue reference, tagging, and merge checklist.
Linked Issues check ✅ Passed The PR updates the public login label to "Log in" and adds matching locale keys, satisfying #16584.
Out of Scope Changes check ✅ Passed The locale edits and button text change are directly tied to the authentication terminology fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 24, 2026

Copy link
Copy Markdown

Greptile Summary

Updates the public login terminology from “Sign in” to “Log in.”

  • Adds the English log_in translation key and removes the former English sign_in key.
  • Updates LoginHeader to use log_in.
  • Removes the existing sign_in entry from the Malayalam catalog.

Confidence Score: 4/5

The PR should not merge until the unintended direct modification to the Crowdin-managed Malayalam catalog is reverted.

The attempted response to the previous review thread removes an established Malayalam translation rather than leaving the non-English locale file unchanged for Crowdin.

Files Needing Attention: public/locale/ml.json

Important Files Changed

Filename Overview
public/locale/en.json Adds the English log_in label and removes the superseded sign_in key.
public/locale/ml.json Still directly modifies the Crowdin-managed Malayalam catalog by deleting a pre-existing translation.
src/components/Common/LoginHeader.tsx Changes the public login button to use the new log_in translation key.

Reviews (3): Last reviewed commit: "fix: use consistent 'Log in' terminology..." | Re-trigger Greptile

Comment thread public/locale/ml.json Outdated
Copilot AI review requested due to automatic review settings July 24, 2026 17:27
@Jayant-Sharma-Dev
Jayant-Sharma-Dev force-pushed the fix/sign-in-log-in-terminology branch from 9688a68 to ed0a6d5 Compare July 24, 2026 17:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@rithviknishad rithviknishad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the "sign_in" key from translations after confirming it's not used elsewhere?

Copilot AI review requested due to automatic review settings July 25, 2026 11:53
@Jayant-Sharma-Dev
Jayant-Sharma-Dev force-pushed the fix/sign-in-log-in-terminology branch from ed0a6d5 to 911255c Compare July 25, 2026 11:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Jayant-Sharma-Dev

Copy link
Copy Markdown
Author

remove the "sign_in" key from translations after confirming it's not used elsewhere?

Checked ...sign_in isn't used anywhere in the codebase anymore .Removed it from both en.json and ml.json.

@github-actions github-actions Bot added needs-triage question Further information is requested labels Jul 25, 2026
Comment thread public/locale/ml.json
"show_patient_presets": "രോഗിയുടെ പ്രീസെറ്റുകൾ കാണിക്കുക",
"show_unread_notifications": "വായിക്കാത്തത് കാണിക്കുക",
"sign_in": "സൈൻ ഇൻ",
"sign_out": "ലോഗ് ഔട്ട് ചെയ്യുക/പുറത്തിറങ്ങുക",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Deletes Crowdin-managed translation

When this branch is merged or synchronized with Crowdin, this deletion removes the pre-existing Malayalam sign_in translation instead of leaving the non-English catalog unchanged, causing the established translation to be lost and the direct edit to conflict with the repository's Crowdin-managed workflow.

Context Used: CLAUDE.md (source)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rithviknishad Sir so shall I again add sign_in in ml.json?

@Jayant-Sharma-Dev

Copy link
Copy Markdown
Author

@NikhilA8606 Any changes ?

@nihal467 nihal467 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the page is being fully redesigned, so the issue is not relevant anymore

@nihal467 nihal467 closed this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use consistent authentication terminology between "Sign in" button and authentication page

4 participants