Fixes Appointment slots query cache key omits resource type/id - #16595
Fixes Appointment slots query cache key omits resource type/id#16595pratx08 wants to merge 5 commits into
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughChangesAppointment slots query
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryCorrectly scopes appointment-slot caching to the resolved scheduling resource.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/pages/Appointments/AppointmentsPage.tsx | Updates the slot query key and request body to consistently use the selected scheduling resource identity without introducing a blocking failure. |
Reviews (3): Last reviewed commit: "Merge branch 'ISSUE-16518' of https://gi..." | Re-trigger Greptile
Do not change the merge checklist in the pr template! |
Hey @NikhilA8606 , have addressed the change. |
nihal467
left a comment
There was a problem hiding this comment.
- can you add the video of the bug and what was resolved
Proposed Changes
Fixes #16518
Include
resourceTypeand the resolved resource ID in the appointment slots query key.Reuse the same resolved resource ID in both the query key and request body.
Prevent cached availability from one resource being temporarily displayed for another resource at the same facility and date.
No behavior changes beyond correctly scoping the TanStack Query cache.
Tagging: @ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
Summary