Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[QA-223] Add per-file E2E config override seam for patient registration #16585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
[QA-223] Add per-file E2E config override seam for patient registration #16585
Changes from 1 commit
58ff07706b61b090d2e74047ddcf7a2b1c1File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
E2EConfigOverridesandCareE2EConfigduplicate the same override contract across app and test code. Both types describe the identicalwindow.__CARE_E2E_CONFIG__shape by hand, with no import relationship, so the two can silently drift out of sync as fields are added or changed.care.config.ts#L53-L78: exportE2EConfigOverrides(or an equivalent shared type) so it can be reused, instead of keeping it private to this module.tests/helper/careConfig.ts#L10-L13: import the exported type fromcare.config.ts(or a shared location both files can reach) instead of redeclaringCareE2EConfigindependently; verify the tests' tsconfig/build setup permits importing fromsrcbefore doing so.📍 Affects 2 files
care.config.ts#L53-L78(this comment)tests/helper/careConfig.ts#L10-L13🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test checks
additionalDetailsSectionText?.toLowerCase().includes("optional")to decide whether to click and expand the "Additional Details" section, mirroring the same pattern already infillAdditionalDetails. If the section is collapsed but its label text doesn't contain "optional" (e.g. the label changes or the section is required in a different locale), theifblock is skipped, the section remains closed, and the subsequentgetByRole("textbox", { name: "Address" })fill will fail silently or throw. Checkingaria-expandedon the trigger button would be a more robust signal of the section's open/closed state.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Shape duplicates
E2EConfigOverridesincare.config.ts.Both types describe the same override contract but are maintained independently. See the consolidated comment for the shared fix across both files.
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.