Skip to content

[QA-214] Fix flaky device service history edit flow test #16572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nihal467 wants to merge 9 commits into
base: develop
Choose a base branch
from
+95 −50
Open

[QA-214] Fix flaky device service history edit flow test #16572

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6456c18
test: fix flaky device service history edit flow
nihal467 Jul 15, 2026
7dedb17
test: scope edit-sheet interactions to dialog to fix strict-mode viol…
Copilot Jul 15, 2026
bd42346
test: wait for Add sheet close and drop hard-coded dialog title
nihal467 Jul 16, 2026
13cd444
test: clarify edit-sheet scoping comment
nihal467 Jul 16, 2026
3b98c94
test: prevent prescription highlight flake via distinct medicines
nihal467 Jul 16, 2026
07a73d6
test: harden cross-user file access test against shared-patient state
nihal467 Jul 16, 2026
3f14a6c
test: narrow dialog locators to avoid strict-mode multi-match
nihal467 Jul 16, 2026
7fc96bb
Merge branch 'develop' into fix/device-service-history-edit-flake
nihal467 Jul 16, 2026
221c36d
test: drop hardcoded timeouts, rely on global config
nihal467 Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions tests/facility/settings/devices/deviceServiceHistory.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,27 @@ test.describe("Device Service History", () => {
.first()
.click();

// Scope all edit-sheet interactions to its dialog to avoid strict-mode
// violations when the Add sheet is still in the DOM during its close animation.
const editSheet = page.getByRole("dialog", {
name: "Edit Service Record",
});
await expect(editSheet).toBeVisible({ timeout: 10000 });
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

const pastYear = new Date().getFullYear() - 1;
await page
await editSheet
.locator('[data-slot="form-item"]')
.filter({ hasText: "Service Date" })
.locator('[data-slot="popover-trigger"]')
.click();
await page.locator(".rdp-years_dropdown").selectOption(pastYear.toString());
await page.locator('[role="gridcell"]:not([data-outside])').first().click();

await page.getByRole("textbox", { name: "Notes *" }).fill(updatedNotes);
await editSheet
.getByRole("textbox", { name: "Notes *" })
.fill(updatedNotes);

await page.getByRole("button", { name: "Update" }).click();
await editSheet.getByRole("button", { name: "Update" }).click();

const updatedCard = page
.locator('[data-slot="card"]')
Expand Down Expand Up @@ -183,14 +192,21 @@ test.describe("Device Service History", () => {
.first()
.click();

const updateButton = page.getByRole("button", { name: "Update" });
// Scope all edit-sheet interactions to its dialog to avoid strict-mode
// violations when the Add sheet is still in the DOM during its close animation.
const editSheet = page.getByRole("dialog", {
name: "Edit Service Record",
});
await expect(editSheet).toBeVisible({ timeout: 10000 });

const updateButton = editSheet.getByRole("button", { name: "Update" });
await expect(updateButton).toBeDisabled();

await page.getByRole("textbox", { name: "Notes *" }).fill(updatedNotes);
await editSheet.getByRole("textbox", { name: "Notes *" }).fill(updatedNotes);

await expect(updateButton).toBeEnabled();

await page.getByRole("textbox", { name: "Notes *" }).fill(notes);
await editSheet.getByRole("textbox", { name: "Notes *" }).fill(notes);

await expect(updateButton).toBeDisabled();
});
Expand Down
Loading