-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Consolidate Sentry initialization: single init, opt-in DSN, URL scrubbing #16526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bodhish
wants to merge
16
commits into
issues/16507/vitest-typecheck-ci
Choose a base branch
from
issues/16508/sentry-init-consolidation
base: issues/16507/vitest-typecheck-ci
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
81770ed
Delete netlify.toml (#16506)
rithviknishad 0a0305e
Skip Daily Playwright Improver on forks without COPILOT_GITHUB_TOKEN …
Copilot c84f51d
fix: single Sentry init with opt-in DSN and URL scrubbing
bodhish 9d4f841
test: add combined UUID-path + query-string scrubUrl case
rithviknishad eab3b75
[CARE-263] Bump versions of dependencies; switch to Node.js v24 (#16396)
bodhish 0389827
ENG-405 Add infinite pagination for prescription list in encounter (#…
NikhilA8606 89a4aee
[ENG-130] Added upload from camera option for service requests (#16367)
NikhilA8606 ac03ee2
[ENG-308] add JIRA validation workflow for pull request title (#16358)
abhimanyurajeesh 8160376
[ENG-663] fix: form style issues (#16494)
navaspavil 16a6eb8
move `dompurify` package to dependencies (#16532)
rithviknishad 1c75e6b
[ENG-744] Highlight dosages when they aren't 1 (#16562)
amjithtitus09 3370484
Register Components for Plugins using Vite (#16445)
gigincg dd3299d
rebuild package-lock with nodev4
gigincg 83d48a0
[QA-210] Allow QA project key in PR title JIRA validation (#16569)
nihal467 25ee097
chore: begin merge conflict resolution with develop
Copilot 41e49ed
merge: resolve conflicts with develop (node 24, knip, vitest, initApp)
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
|
|
||
| import { scrubUrl } from "@/Integrations/Sentry"; | ||
|
|
||
| describe("scrubUrl", () => { | ||
| it("strips query strings", () => { | ||
| expect(scrubUrl("/patients?phone_number=999")).toBe("/patients"); | ||
| }); | ||
|
|
||
| it("replaces UUID path segments", () => { | ||
| expect( | ||
| scrubUrl( | ||
| "/facility/0198aaaa-1111-7bbb-8ccc-2ddddddddddd/patients/0198bbbb-2222-7ccc-8ddd-3eeeeeeeeeee/encounter", | ||
| ), | ||
| ).toBe("/facility/<id>/patients/<id>/encounter"); | ||
| }); | ||
|
|
||
| it("strips query strings and replaces UUID path segments together", () => { | ||
| expect( | ||
| scrubUrl( | ||
| "/facility/0198aaaa-1111-7bbb-8ccc-2ddddddddddd/patients?phone_number=999", | ||
| ), | ||
| ).toBe("/facility/<id>/patients"); | ||
| }); | ||
|
|
||
| it("leaves non-sensitive urls intact", () => { | ||
| expect(scrubUrl("/login")).toBe("/login"); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.