fix(ir): Add support for byte format in string validation#1296
Open
k4n4ry wants to merge 2 commits intoogen-go:mainfrom
Open
fix(ir): Add support for byte format in string validation#1296k4n4ry wants to merge 2 commits intoogen-go:mainfrom
k4n4ry wants to merge 2 commits intoogen-go:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
+ Coverage 73.92% 73.93% +0.01%
==========================================
Files 189 189
Lines 12855 12860 +5
==========================================
+ Hits 9503 9508 +5
Misses 2804 2804
Partials 548 548 ☔ View full report in Codecov by Sentry. |
Member
|
I think this should be opt-in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1261
Overview
I've added a new
Bytefield to theStringstructure in thevalidatepackage.This field is set to true when
format: byteis specified in the string formats of OpenAPI.When executing character length validation, if the
Bytefield is true, the length is verified using []byte instead of []rune.Note
This change may not be necessary.
According to the OpenAPI specification,
format: byteis specified for base64-encoded characters.If the characters used are those in base64 encoding, the length evaluation doesn't change during the
[]byte -> string -> []runeconversion process.However, as mentioned in the issue, I suppose this change is necessary if we want to ensure validation behavior for more general bytes fields.