[FIX] devtools: get OWL 3 root nodes through the mount promise - #1998
Merged
Conversation
Since 3700cad, roots created by app.createRoot() no longer expose their ComponentNode: root.node is undefined, so getRoots() returned an array of undefined for every OWL 3 app and the extension could not inspect any component tree. The node is still reachable through the only remaining public surface: root.promise resolves with the root component instance, whose __owl__ property is its ComponentNode. Since getRoots() is synchronous, cache each root's node in a WeakMap when its promise resolves, and post a RefreshApps message at that point so the devtools re-render once the tree becomes inspectable. Roots whose mount fails resolve to nothing and are simply skipped. root.node is still used when present, for compatibility with earlier 3.x versions that exposed it directly.
juliusc2066
force-pushed
the
mater-devtools-roots-as-promise-juca
branch
from
July 16, 2026 09:07
45a2d82 to
8fd9cf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 3700cad, roots created by app.createRoot() no longer expose their ComponentNode: root.node is undefined, so getRoots() returned an array of undefined for every OWL 3 app and the extension could not inspect any component tree.
The node is still reachable through the only remaining public surface: root.promise resolves with the root component instance, whose owl property is its ComponentNode. Since getRoots() is synchronous, cache each root's node in a WeakMap when its promise resolves, and post a RefreshApps message at that point so the devtools re-render once the tree becomes inspectable. Roots whose mount fails resolve to nothing and are simply skipped.
root.node is still used when present, for compatibility with earlier 3.x versions that exposed it directly.