Skip to content

Fixed compilation errors - #131

Merged
karl-zylinski merged 2 commits into
odin-lang:masterfrom
GCodergr:fix/examples-win32-game-of-life
Oct 2, 2025
Merged

karl-zylinski merged 2 commits into
odin-lang:masterfrom
GCodergr:fix/examples-win32-game-of-life

Conversation

@GCodergr

Copy link
Copy Markdown
Contributor

Fixed compilation errors for win32/game_of_life example.

Checklist before submitting:

  • This example has been added to .github/workflows/check.yml (for automatic testing)
  • This example compiles cleanly with flags -vet -strict-style -vet-tabs -disallow-do -warnings-as-errors
  • This example follows the core naming convention: https://github.com/odin-lang/Odin/wiki/Naming-Convention (exception can be made for ports of examples that need to match 1:1 to the original source).
  • By submitting, I understand that this example is made available under these licenses: Public Domain and Odin's BSD-3 license. Only for third-party dependencies are other licenses allowed.

@karl-zylinski

Copy link
Copy Markdown
Collaborator

Thank you. Because of the new string16 stuff, you can actually remove that L procedure and use the string constant / literal straight up: class_name := L("OdinMainClass") -> just do CLASS_NAME :: "OdinMainClass".

You can put the CLASS_NAME as a global constant since its used in few places.

Essentially any place where L is used, you can use the constant straight into the win32 procs.

@karl-zylinski
karl-zylinski merged commit 608a7fb into odin-lang:master Oct 2, 2025
1 check failed
@karl-zylinski

Copy link
Copy Markdown
Collaborator

I fixed the additional things and merged it. Thanks!

@GCodergr

GCodergr commented Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

I fixed the additional things and merged it. Thanks!

Thank you Karl! I really appreciate all the hard work you put into those things! 🙏

I’m a little busy with work, so I didn’t have time to check and update the code myself.
But you’re more experienced than me with the Win32 API anyway. 😃

Thanks again!

@GCodergr
GCodergr deleted the fix/examples-win32-game-of-life branch October 4, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants