TextAlignedV(): better handling of cursor position and DC boundary#9455
Open
dkosmari wants to merge 1 commit into
Open
TextAlignedV(): better handling of cursor position and DC boundary#9455dkosmari wants to merge 1 commit into
dkosmari wants to merge 1 commit into
Conversation
…window DC boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
TextAlignedV()leaves the position and boundary in an inconsistent state, that limits its usefulness.With this PR:
widthwidth (parameter was calledsize_xbefore), unless:width == 0means the real text width, as obtained byCalcTextSize().x. Before,size_x == 0was giving me no rendered output, as if it was actually clipping the text to a zero-width region.width < 0meansContentRegionAvail().x.Here's a test code (call
test_text_aligned()from any example code), showing the bounding box, cursor position behavior, and how it behaves inside table cells:Here are images showing different outputs: