Better QT and GTK theming by danxliu · Pull Request #232 · ocf/nix

danxliu · 2026-04-02T23:26:35Z

Analyze PR state and review comments
Fix unquoted path variables in sed/ln commands in the cosmictheme-dark service script
Guard KVANTUM_THEME_FILE initialization for existing users, with smart theme default based on OCF theme preference
Final code review and security scan

* use openssh_gssapi for sshd on all hosts * GSSAPIKeyExchange = yes if host has a keytab * test an option * ticket forwarding flag * undo unhelpful option * test without specifying openssh package * implement oliver suggestions --------- Co-authored-by: 24apricots <michaelzls@berkeley.edu>

This reverts commit a80d562.

* gh actions: make build workflow actually build `--evaluator streaming` would be preferable, but it results in colmena exiting as successful after 2 seconds without doing anything, even if nix-eval-jobs is installed. * gh actions: enable verbose builds * fix eval warning on builds fixes the remaining evaluation warnings for: 'system' has been renamed to/replaced by 'stdenv.hostPlatform.system'

This reverts commit 8c63f92.

Copilot

Pull request overview

Updates the graphical NixOS profile and skel configuration to improve consistent theming across Qt and GTK apps in COSMIC, including reacting to light/dark mode changes and respecting an existing OCF theme setting at startup.

Changes:

Add default qt5ct/qt6ct configuration in skel and enable COSMIC Tk global theme application.
Install Qt/GTK theme packages and enable xdg-desktop-portal-gtk.
Extend the COSMIC theme watcher to sync Qt style (qt5ct/qt6ct) and seed COSMIC theme from the persisted OCF theme on startup; add a new nixpkgs-unstable flake input.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
modules/graphical/skel/.config/qt6ct/qt6ct.conf	Adds default Qt6ct appearance settings (icon theme, dialogs, style).
modules/graphical/skel/.config/qt5ct/qt5ct.conf	Adds default Qt5ct appearance settings (icon theme, dialogs, style).
modules/graphical/skel/.config/cosmic/com.system76.CosmicTk/v1/apply_theme_global	Enables COSMIC Tk global theme application in skel.
modules/graphical/default.nix	Enables xdg portal GTK, installs theming packages, sets Qt platform theme env var, and syncs Qt style on theme changes.
flake.nix	Adds a `nixpkgs-unstable` flake input.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-02T23:30:21Z

modules/graphical/default.nix

+          preferences = {
+            "widget.gtk.libadwaita-colors.enabled" = false;


programs.firefox.preferences doesn't appear to be a valid NixOS option in this repo (other Firefox config uses programs.firefox.policies.Preferences). As written, this is likely to fail evaluation with “option does not exist”. Consider moving this setting under programs.firefox.policies.Preferences (with the expected { Value = ...; Status = ...; } structure) or using the existing browsers module to carry this preference.

Suggested change

preferences = {

"widget.gtk.libadwaita-colors.enabled" = false;

policies.Preferences = {

"widget.gtk.libadwaita-colors.enabled" = {

Value = false;

Status = "default";

};

Copilot · 2026-04-02T23:30:22Z

modules/graphical/default.nix

        ];

+        environment.sessionVariables = {
+          QT_QPA_PLATFORMTHEME = "qt5ct";


QT_QPA_PLATFORMTHEME is set to qt5ct, but this PR also installs/configures qt6ct. With the current env var, Qt6 apps typically won't load the qt6ct platform theme plugin, so the ~/.config/qt6ct/qt6ct.conf changes may never take effect. Please adjust the session environment (or use wrappers) so both Qt5 and Qt6 apps pick up the intended theming.

Suggested change

QT_QPA_PLATFORMTHEME = "qt5ct";

QT_QPA_PLATFORMTHEME = "gtk3";

hallucination

Copilot · 2026-04-02T23:30:22Z

modules/graphical/default.nix

                  sed -i -E 's/bg-(light|dark)/bg-dark/g' $COSMIC_BG_FILE
                  sed -i 's/theme = "rose-pine-dawn"/theme = "rose-pine"/' $HOME/.config/halloy/config.toml
+                  # QT Themes
+                  sed -i 's/^style=.*/style=Adwaita-Dark/' $QT5CT_THEME_FILE
+                  sed -i 's/^style=.*/style=Adwaita-Dark/' $QT6CT_THEME_FILE


The sed -i invocations use unquoted path variables (e.g. $COSMIC_BG_FILE, $QT5CT_THEME_FILE, $QT6CT_THEME_FILE). This can break on unexpected characters and also produces noisy errors if the target files don't exist (common for existing users who don't have the new skel files). Quote these paths and guard/initialize the qt5ct/qt6ct config files before editing so the theme sync is reliable.

Copilot · 2026-04-02T23:30:22Z

flake.nix

+
+    nixpkgs-unstable = {
+      type = "github";
+      owner = "nixos";
+      repo = "nixpkgs";
+      ref = "nixos-unstable";
+    };


A new flake input (nixpkgs-unstable) was added, but flake.lock does not contain a corresponding node (verified by searching flake.lock). This will break nix commands that require a locked input set. Please run nix flake lock --update-input nixpkgs-unstable (and commit the lockfile change) or drop the input if it's not needed yet.

Suggested change

nixpkgs-unstable = {

type = "github";

owner = "nixos";

repo = "nixpkgs";

ref = "nixos-unstable";

};

danxliu · 2026-04-03T04:18:03Z

@copilot review please

danxliu · 2026-04-03T04:21:28Z

@waddles review please

… init Agent-Logs-Url: https://github.com/ocf/nix/sessions/49e580a5-421d-49a7-a604-7636f336d607 Co-authored-by: danxliu <75332824+danxliu@users.noreply.github.com>

Copilot · 2026-04-03T04:23:22Z

@copilot review please

Reviewed the current state of the PR. Found and fixed these issues in commit 6abd8ae:

Unquoted path variables — $COSMIC_BG_FILE, $KVANTUM_THEME_FILE, and $HOME/.config/halloy/config.toml were all unquoted in sed commands, and $HOME/.config/Kvantum/... paths were unquoted in ln commands. All are now properly quoted.
KVANTUM_THEME_FILE missing for existing users — The skel file is only copied for new home directories, so existing users wouldn't have ~/.config/Kvantum/kvantum.kvconfig. Added a guard that initializes it if missing, using the OCF theme preference (rose-pine-dawn-iris for light, rose-pine-moon-iris for dark) as the default.

danxliu and others added 19 commits April 1, 2026 19:06

feat: cutecosmic + unstable pkgs + adw-gtk3

f3263fb

feat: xdg portal

56460da

feat: fix typo

6390361

fix: typo

87241da

feat: add icon theme + apply_theme_global

6ab570d

remove papirus theme

54d7b20

feat: remove unstable & cutecosmic, add qt5ct & qt6ct

4c48e2c

fix: remove rest of unstable packages

b04c5fd

fix: change qt5ct package name

8882fd4

feat: integrate with light/dark theme

6550f31

fix: put apply_theme_global in the right spot

bd991c9

fix: persist light/dark theme on new login

fe514e5

67 (#228)

3ceb26e

Revert "set sddm wallpaper to login-afool.png (#225)" (#231)

8f01b15

This reverts commit a80d562.

Revert "67 (#228)" (#230)

5980520

This reverts commit 8c63f92.

feat: cutecosmic + unstable pkgs + adw-gtk3

15d9db9

fix: remove rest of unstable packages

908a2e7

danxliu requested a review from Copilot April 2, 2026 23:26

Merge branch 'main' into icon-theme

4290474

Copilot started reviewing on behalf of danxliu April 2, 2026 23:27 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

danxliu added 7 commits April 2, 2026 16:38

fix: remove unstable pkgs, change env and firefox settings

e1eff8a

fix: remove firefox config

622b559

revert qt5ct env variable

a6c100d

switch to kvantum from qt5ct

c8c4c42

symlink rose pine kvantum themes

6148304

update kvantum with right theme names

c8e7256

feat: add back qt5ct and qt6ct with kvantum

c522f5e

Merge branch 'main' into icon-theme

c04a5d7

fix: quote path variables in sed/ln commands and guard kvantum config…

6abd8ae

… init Agent-Logs-Url: https://github.com/ocf/nix/sessions/49e580a5-421d-49a7-a604-7636f336d607 Co-authored-by: danxliu <75332824+danxliu@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better QT and GTK theming#232

Better QT and GTK theming#232
danxliu wants to merge 29 commits intomainfrom
icon-theme

danxliu commented Apr 2, 2026 •

edited by Copilot AI

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

danxliu Apr 3, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

danxliu Apr 3, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

danxliu Apr 3, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

danxliu Apr 3, 2026

Uh oh!

danxliu commented Apr 3, 2026

Uh oh!

danxliu commented Apr 3, 2026

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		preferences = {
		"widget.gtk.libadwaita-colors.enabled" = false;

-          preferences = {
-            "widget.gtk.libadwaita-colors.enabled" = false;
+          policies.Preferences = {
+            "widget.gtk.libadwaita-colors.enabled" = {
+              Value = false;
+              Status = "default";
+            };

	QT_QPA_PLATFORMTHEME = "qt5ct";
	QT_QPA_PLATFORMTHEME = "gtk3";

Conversation

danxliu commented Apr 2, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

danxliu Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

danxliu Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

danxliu Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

danxliu Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

danxliu commented Apr 3, 2026

Uh oh!

danxliu commented Apr 3, 2026

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

danxliu commented Apr 2, 2026 •

edited by Copilot AI

Loading