[new release] coq-lsp (0.2.3+8.20) - #27990
Merged
Merged
Conversation
CHANGES: ------------------------ - [fleche] fix quick fixes for errors being lost due to incorrect handling of `send_diags_extra_data` (@ejgallego, rocq-community/rocq-lsp#850) - [vscode] Syntax highlighting for Coq 8.17-8.20 (@4ever2, rocq-community/rocq-lsp#872) - [build] Adapt to Coq -> Rocq renaming (@ejgallego, @proux, rocq-community/rocq-lsp#879) - [js worker] Update js_of_ocaml to 5.9.1 , thanks a lot to Hugo Heuzard for longstanding continued support of the jsCoq and coq-lsp projects (@ejgallego, @hhugo, rocq-community/rocq-lsp#881) - [js worker] Update stubs (@ejgallego, @hhugo, rocq-community/rocq-lsp#881) - [js worker] Fix build for Coq -> Rocq renaming and stdlib split (@ejgallego, rocq-community/rocq-lsp#881) - [general] Adapt to Coq -> Rocq renaming (@ejgallego, @SkySkimmer, rocq-community/rocq-lsp#883) - [general] [js] Adapt to Rocq stdlib split (@ejgallego, rocq-community/rocq-lsp#890) - [ci] Bump setup-ocaml to v3 (@ejgallego, rocq-community/rocq-lsp#890) - [ci] [windows] Use Opam 2.2 to build on windows (@ejgallego, rocq-community/rocq-lsp#815, rocq-community/rocq-lsp#890) - [petanque] `petanque/start` now fails when the theorem was parsed but not successfully executed (@ejgallego, reported by @gbdrt, rocq-community/rocq-lsp#901, fixes rocq-community/rocq-lsp#886) - [ci] Test Ocaml 5.3 (@ejgallego, rocq-community/rocq-lsp#904) - [js worker] Add Shachar Itzhaky's trampoline patch; this greatly reduces the Stack Overflow in the proof engine (@ejgallego, @corwin-of-amber, rocq-community/rocq-lsp#905) - [js worker] [build] Include Coq WaterProof in the default Web Worker build (@ejgallego, waterproof team, rocq-community/rocq-lsp#905, closes rocq-community/rocq-lsp#888) - [vscode] [web] Fix web extension not exporting the coq-lsp extension API (@ejgallego, reported by @amblafont, rocq-community/rocq-lsp#911, fixes rocq-community/rocq-lsp#877) - [build] [general] Rename our internal `Lsp` library to `Fleche_lsp`; this should help avoiding conflicts with the OCaml `lsp` library (@ejgallego, reported by @blackbird1128, rocq-community/rocq-lsp#912, fixes rocq-community/rocq-lsp#861) - [workspace] Remove support legacy ML-search path semantics. These were basically unused since Coq 8.16. As a consequence, `coq-lsp` / `fcc` don't accept the `-I` flag anymore, use `OCAMLPATH` or the `--ocamlpath=` option to pass extra `findlib` paths. We still respect the -I flag in `_CoqMakefile` (@ejgallego, rocq-community/rocq-lsp#916) - [lsp] [debug] Respect `$/setTrace` call , refactor logging system, and allow file logging of protocol traces again (@ejgallego, rocq-community/rocq-lsp#919, fixes rocq-community/rocq-lsp#868) - [coq] Support Coq relocatable mode (@SkySkimmer, rocq-community/rocq-lsp#891) - [ci] [deps] Remove support for OCaml 4.12 and 4.13, following upstream's rocq-prover/rocq#20576 Note that these compiler versions have been unsupported for a long time, please upgrade (@ejgallego, rocq-community/rocq-lsp#951) - [hover] New option `show_state_hash_on_hover` that displays state hash on hover for debug (@ejgallego, rocq-community/rocq-lsp#954) - [doc] [faq] Updated FAQ to account for VSCoq 2 release in 2023, thanks to Patrick Nicodemus for pointing out the outdated documentation (@ejgallego, rocq-community/rocq-lsp#846, fixes rocq-community/rocq-lsp#817) - [vscode] [macos] Resolve keybinding conflict with Cmd+N and Cmd+Enter, we now use Alt+N and Alt+Shift+Enter, (Andrei Listochkin, rocq-community/rocq-lsp#926) - [rocq] [fleche] Disable memprof-limits interruption backend by default, as released Rocq versions are not safe yet. If you want to enable it, you can still do it with the `--int_backend=Mp` command line option (@ejgallego, rocq-community/rocq-lsp#957, fixes rocq-community/rocq-lsp#857, reported by @dariusf, cc: rocq-prover/rocq#19177) - [lsp] [controller] Include Rocq feedback on request errors, using the optional `data` field. This is useful to still be able to obtain feedback messages such as debug messages even when a request fails. This also opens the door to better protocol handling and petanque integration (@ejgallego, rocq-community/rocq-lsp#959, rocq-community/rocq-lsp#961) - [petanque] Add feedback field to `Run_result.t`, this is important for many use cases. We also return feedback on petanque errors. (@ejgallego, @JulesViennotFranca, rocq-community/rocq-lsp#960) - [petanque] new `get_state_at_pos` and `get_root_state` calls, that allow to retrieve a petanque proof state from position (@JulesViennotFranca, @ejgallego, rocq-community/rocq-lsp#962) - [doc] [petanque] Document petanque v1, improve readme (@ejgallego, rocq-community/rocq-lsp#963) - [plugin] [astdump] Make the JSON and SEXP output into a line per object by default (@blackbird1128, @ejgallego, rocq-community/rocq-lsp#874) - [doc] [emacs] [protocol] Improve documentation for `proof/goals`, add link to official emacs mode by Josselin Poiret (@ejgallego, rocq-community/rocq-lsp#969, thanks to @jpoiret, cc: rocq-community/rocq-lsp#941) - [goals] Include `range` in `proof/goals` answer. This is useful for clients willing to do highlighting (@ejgallego, @jpoiret, rocq-community/rocq-lsp#970)
Contributor
|
same as v9, likely a regression of opam, tests pass for opam-2.3, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Language Server Protocol native server for Coq
CHANGES:
handling of
send_diags_extra_data(@ejgallego, [web worker] Allow users to select different Coq versions rocq-community/rocq-lsp#850)Heuzard for longstanding continued support of the jsCoq and coq-lsp
projects (@ejgallego, @hhugo, [js worker] Update js_of_ocaml to 5.9.1 and Coq -> Roqc / stdlib split rocq-community/rocq-lsp#881)
(@ejgallego, [js worker] Update js_of_ocaml to 5.9.1 and Coq -> Roqc / stdlib split rocq-community/rocq-lsp#881)
Adapt to coq/coq#19927 (coq-core renamed to rocq-runtime) rocq-community/rocq-lsp#883)
[build] Adapt to Rocq stdlib split + fix setup-ocaml CI rocq-community/rocq-lsp#890)
petanque/startnow fails when the theorem was parsedbut not successfully executed (@ejgallego, reported by @gbdrt,
[petanque] Fix
petanque/startwhen a theorem is parsed but has errors rocq-community/rocq-lsp#901, fixes [petanque] Return error onstartwhen there is no proof to build. rocq-community/rocq-lsp#886)reduces the Stack Overflow in the proof engine (@ejgallego,
@corwin-of-amber, [build] [js] Add coq-waterproof to JS build. rocq-community/rocq-lsp#905)
Worker build (@ejgallego, waterproof team, [build] [js] Add coq-waterproof to JS build. rocq-community/rocq-lsp#905, closes [build] [js] Coq WaterProof build for coq-lsp.js rocq-community/rocq-lsp#888)
extension API (@ejgallego, reported by @amblafont, [vscode] [web] Fix web extension not exporting the coq-lsp API rocq-community/rocq-lsp#911, fixes
The web extension does not export any API rocq-community/rocq-lsp#877)
Lsplibrary toFleche_lsp; this should help avoiding conflicts with the OCamllsplibrary (@ejgallego, reported by @blackbird1128, [build] [general] Rename our internalLsplibrary toFleche_lsprocq-community/rocq-lsp#912, fixesname conflict with the lsp package rocq-community/rocq-lsp#861)
were basically unused since Coq 8.16. As a consequence,
coq-lsp/fccdon't accept the-Iflag anymore, useOCAMLPATHor the--ocamlpath=option to pass extrafindlibpaths. We stillrespect the -I flag in
_CoqMakefile(@ejgallego, [coq] [workspace] Remove machinery for old-style manual ML path handling rocq-community/rocq-lsp#916)$/setTracecall , refactor logging system,and allow file logging of protocol traces again (@ejgallego, [lsp] Cleanup of LSP IO rocq-community/rocq-lsp#919,
fixes [debug] [ui] Provide an easier way to output a protocol trace. rocq-community/rocq-lsp#868)
upstream's Bump minimum ocaml version to 4.14.0 rocq-prover/rocq#20576 Note that these compiler versions have
been unsupported for a long time, please upgrade (@ejgallego, [ci] [deps] Remove support for OCaml 4.12 and 4.13 rocq-community/rocq-lsp#951)
show_state_hash_on_hoverthat displays statehash on hover for debug (@ejgallego, [hover] Improve API to enable/disable hover plugins rocq-community/rocq-lsp#954)
thanks to Patrick Nicodemus for pointing out the outdated
documentation (@ejgallego, [faq] Update FAQ for VsCoq 2 release. rocq-community/rocq-lsp#846, fixes Clarify the difference between VsCoq 1 and VsCoq 2 here? rocq-community/rocq-lsp#817)
Cmd+Enter, we now use Alt+N and Alt+Shift+Enter, (Andrei
Listochkin, VSCode extension keybindings shouldn't conflict with editor defaults. rocq-community/rocq-lsp#926)
default, as released Rocq versions are not safe yet. If you want to
enable it, you can still do it with the
--int_backend=Mpcommandline option (@ejgallego, [rocq] Disable memprof-limits interruption backend by default rocq-community/rocq-lsp#957, fixes 0.2.0 crashes frequently rocq-community/rocq-lsp#857, reported by @dariusf,
cc: [core] Improved state protection against memprof-limits interruptions rocq-prover/rocq#19177)
the optional
datafield. This is useful to still be able toobtain feedback messages such as debug messages even when a request
fails. This also opens the door to better protocol handling and
petanque integration (@ejgallego, [controller] [lsp] Include Rocq feedback on request errors. rocq-community/rocq-lsp#959, [fleche] [lsp] Uniformize feedback type with message, bugfixes for #961 rocq-community/rocq-lsp#961)
Run_result.t, this is importantfor many use cases. We also return feedback on petanque errors.
(@ejgallego, @JulesViennotFranca, [petanque] Add feedback field to errors and
Run_result.trocq-community/rocq-lsp#960)get_state_at_posandget_root_statecalls, thatallow to retrieve a petanque proof state from position
(@JulesViennotFranca, @ejgallego, [petanque] Add
get_statecalls rocq-community/rocq-lsp#962)[doc] [petanque] [readme] Document and version petanque, improve README. rocq-community/rocq-lsp#963)
object by default (@blackbird1128, @ejgallego, [plugins] Fix the output of the AST dump plugin to be valid JSON rocq-community/rocq-lsp#874)
proof/goals,add link to official emacs mode by Josselin Poiret (@ejgallego,
[doc] Some improvements to
proof/goalsdoc, emacs link. rocq-community/rocq-lsp#969, thanks to @jpoiret, cc:errorfield ofproof/goalsdoes not respectgoal_after_tacticrocq-community/rocq-lsp#941)rangeinproof/goalsanswer. This is useful forclients willing to do highlighting (@ejgallego, @jpoiret, [goals] Include sentence
rangeinproof/goalsanswer. rocq-community/rocq-lsp#970)