Skip to content

Fix from atdgen revdeps#27325

Merged
mseri merged 11 commits intoocaml:masterfrom
mseri:atd
Jan 27, 2025
Merged

Fix from atdgen revdeps#27325
mseri merged 11 commits intoocaml:masterfrom
mseri:atd

Conversation

@mseri
Copy link
Copy Markdown
Member

@mseri mseri commented Jan 27, 2025

Seen on #27308

mseri added 9 commits January 27, 2025 10:17
```
=== ERROR while compiling calculon-web.0.6 ===================================#
 context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.4.03.0 | pinned(https://github.com/c-cube/calculon/archive/v0.6.tar.gz)
 path                 ~/.opam/4.03/.opam-switch/build/calculon-web.0.6
 command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p calculon-web -j 71
 exit-code            1
 env-file             ~/.opam/log/calculon-web-7-377440.env
 output-file          ~/.opam/log/calculon-web-7-377440.out
       ocamlc src/web/.calculon_web.objs/calculon_web__Giphy_j.{cmo,cmt} (exit 2)
 (cd _build/default && /home/opam/.opam/4.03/bin/ocamlc.opt -w -40 -g -bin-annot -I src/web/.calculon_web.objs -I src/web/.calculon_web.objs/.private -I /home/opam/.opam/4.03/lib/ISO8601 -I /home/opam/.opam/4.03/lib/atd -I /home/opam/.opam/4.03/lib/atdgen -I /home/opam/.opam/4.03/lib/biniou -I /home/opam/.opam/4.03/lib/bytes -I /home/opam/.opam/4.03/lib/calculon -I /home/opam/.opam/4.03/lib/containers -I /home/opam/.opam/4.03/lib/curly -I /home/opam/.opam/4.03/lib/easy-format -I /home/opam/.opam/4.03/lib/irc-client -I /home/opam/.opam/4.03/lib/irc-client-lwt -I /home/opam/.opam/4.03/lib/irc-client-lwt-ssl -I /home/opam/.opam/4.03/lib/lambdasoup -I /home/opam/.opam/4.03/lib/logs -I /home/opam/.opam/4.03/lib/lwt -I /home/opam/.opam/4.03/lib/lwt_ssl -I /home/opam/.opam/4.03/lib/re -I /home/opam/.opam/4.03/lib/re/perl -I /home/opam/.opam/4.03/lib/re/posix -I /home/opam/.opam/4.03/lib/re/str -I /home/opam/.opam/4.03/lib/result -I /home/opam/.opam/4.03/lib/ssl -I /home/opam/.opam/4.03/lib/stringext -I /home/opam/.opam/4.03/lib/uri -I /home/opam/.opam/4.03/lib/yojson -intf-suffix .ml -no-alias-deps -open Calculon_web -o src/web/.calculon_web.objs/calculon_web__Giphy_j.cmo -c -impl src/web/Giphy_j.ml)
 File "src/web/Giphy_j.ml", line 26, characters 17-42:
 Error: Unbound value Yojson.Safe.write_t
 Hint: Did you mean write_int?
```

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Fails with
```
=== ERROR while compiling github.4.3.1 =======================================#
 context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.4.03.0 | pinned(https://github.com/mirage/ocaml-github/releases/download/4.3.1/github-unix-4.3.1.tbz)
 path                 ~/.opam/4.03/.opam-switch/build/github.4.3.1
 command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p github -j 255
 exit-code            1
 env-file             ~/.opam/log/github-7-8bfeb8.env
 output-file          ~/.opam/log/github-7-8bfeb8.out
     ocamlopt lib/.github.objs/native/github_j.{cmx,o} (exit 2)
 (cd _build/default && /home/opam/.opam/4.03/bin/ocamlopt.opt -w -40 -principal -strict-sequence -g -safe-string -w A-E-41-42-44-48 -w -27-32 -g -I lib/.github.objs/byte -I lib/.github.objs/native -I /home/opam/.opam/4.03/lib/atdgen -I /home/opam/.opam/4.03/lib/atdgen-runtime -I /home/opam/.opam/4.03/lib/base -I /home/opam/.opam/4.03/lib/base/caml -I /home/opam/.opam/4.03/lib/base/shadow_stdlib -I /home/opam/.opam/4.03/lib/base64 -I /home/opam/.opam/4.03/lib/biniou -I /home/opam/.opam/4.03/lib/bytes -I /home/opam/.opam/4.03/lib/cohttp -I /home/opam/.opam/4.03/lib/cohttp-lwt -I /home/opam/.opam/4.03/lib/easy-format -I /home/opam/.opam/4.03/lib/fieldslib -I /home/opam/.opam/4.03/lib/lwt -I /home/opam/.opam/4.03/lib/re -I /home/opam/.opam/4.03/lib/result -I /home/opam/.opam/4.03/lib/seq -I /home/opam/.opam/4.03/lib/sexplib -I /home/opam/.opam/4.03/lib/sexplib/0 -I /home/opam/.opam/4.03/lib/stringext -I /home/opam/.opam/4.03/lib/uri -I /home/opam/.opam/4.03/lib/yojson -intf-suffix .ml -no-alias-deps -o lib/.github.objs/native/github_j.cmx -c -impl lib/github_j.ml)
 File "lib/github_j.ml", line 5064, characters 14-39:
 Error: Unbound value Yojson.Safe.write_t
 Hint: Did you mean write_int?
       ocamlc lib/.github.objs/byte/github_j.{cmo,cmt} (exit 2)
 (cd _build/default && /home/opam/.opam/4.03/bin/ocamlc.opt -w -40 -principal -strict-sequence -g -safe-string -w A-E-41-42-44-48 -w -27-32 -g -bin-annot -I lib/.github.objs/byte -I /home/opam/.opam/4.03/lib/atdgen -I /home/opam/.opam/4.03/lib/atdgen-runtime -I /home/opam/.opam/4.03/lib/base -I /home/opam/.opam/4.03/lib/base/caml -I /home/opam/.opam/4.03/lib/base/shadow_stdlib -I /home/opam/.opam/4.03/lib/base64 -I /home/opam/.opam/4.03/lib/biniou -I /home/opam/.opam/4.03/lib/bytes -I /home/opam/.opam/4.03/lib/cohttp -I /home/opam/.opam/4.03/lib/cohttp-lwt -I /home/opam/.opam/4.03/lib/easy-format -I /home/opam/.opam/4.03/lib/fieldslib -I /home/opam/.opam/4.03/lib/lwt -I /home/opam/.opam/4.03/lib/re -I /home/opam/.opam/4.03/lib/result -I /home/opam/.opam/4.03/lib/seq -I /home/opam/.opam/4.03/lib/sexplib -I /home/opam/.opam/4.03/lib/sexplib/0 -I /home/opam/.opam/4.03/lib/stringext -I /home/opam/.opam/4.03/lib/uri -I /home/opam/.opam/4.03/lib/yojson -intf-suffix .ml -no-alias-deps -o lib/.github.objs/byte/github_j.cmo -c -impl lib/github_j.ml)
 File "lib/github_j.ml", line 5064, characters 14-39:
 Error: Unbound value Yojson.Safe.write_t
 Hint: Did you mean write_int?
```

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Fails with
```
 (cd _build/default && /home/opam/.opam/4.08/bin/ocamlc.opt -w -40 -g -bin-annot -I src/.cosmos.objs/byte -I /home/opam/.opam/4.08/lib/asn1-combinators -I /home/opam/.opam/4.08/lib/astring -I /home/opam/.opam/4.08/lib/atd -I /home/opam/.opam/4.08/lib/atdgen -I /home/opam/.opam/4.08/lib/base -I /home/opam/.opam/4.08/lib/base/caml -I /home/opam/.opam/4.08/lib/base/shadow_stdlib -I /home/opam/.opam/4.08/lib/base64 -I /home/opam/.opam/4.08/lib/biniou -I /home/opam/.opam/4.08/lib/bytes -I /home/opam/.opam/4.08/lib/cohttp -I /home/opam/.opam/4.08/lib/cohttp-lwt -I /home/opam/.opam/4.08/lib/cohttp-lwt-unix -I /home/opam/.opam/4.08/lib/conduit -I /home/opam/.opam/4.08/lib/conduit-lwt -I /home/opam/.opam/4.08/lib/conduit-lwt-unix -I /home/opam/.opam/4.08/lib/cryptokit -I /home/opam/.opam/4.08/lib/cstruct -I /home/opam/.opam/4.08/lib/cstruct-lwt -I /home/opam/.opam/4.08/lib/cstruct-sexp -I /home/opam/.opam/4.08/lib/easy-format -I /home/opam/.opam/4.08/lib/fieldslib -I /home/opam/.opam/4.08/lib/fmt -I /home/opam/.opam/4.08/lib/ipaddr -I /home/opam/.opam/4.08/lib/ipaddr/unix -I /home/opam/.opam/4.08/lib/logs -I /home/opam/.opam/4.08/lib/lwt -I /home/opam/.opam/4.08/lib/lwt/unix -I /home/opam/.opam/4.08/lib/magic-mime -I /home/opam/.opam/4.08/lib/mmap -I /home/opam/.opam/4.08/lib/netstring -I /home/opam/.opam/4.08/lib/netsys -I /home/opam/.opam/4.08/lib/nocrypto -I /home/opam/.opam/4.08/lib/ocaml/threads -I /home/opam/.opam/4.08/lib/parsexp -I /home/opam/.opam/4.08/lib/ppx_deriving/runtime -I /home/opam/.opam/4.08/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.08/lib/ptime -I /home/opam/.opam/4.08/lib/ptime/os -I /home/opam/.opam/4.08/lib/re -I /home/opam/.opam/4.08/lib/result -I /home/opam/.opam/4.08/lib/seq -I /home/opam/.opam/4.08/lib/sexplib -I /home/opam/.opam/4.08/lib/sexplib0 -I /home/opam/.opam/4.08/lib/stringext -I /home/opam/.opam/4.08/lib/tls -I /home/opam/.opam/4.08/lib/uchar -I /home/opam/.opam/4.08/lib/uri -I /home/opam/.opam/4.08/lib/uri/services -I /home/opam/.opam/4.08/lib/x509 -I /home/opam/.opam/4.08/lib/yojson -I /home/opam/.opam/4.08/lib/zarith -no-alias-deps -open Cosmos -o src/.cosmos.objs/byte/cosmos__Utility.cmo -c -impl src/utility.pp.ml)
 File "src/utility.ml", line 28, characters 13-30:
 28 |   let key =  Base64.decode_exn master_key in
                   ^^^^^^^^^^^^^^^^^
 Error: Unbound module Base64
```

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Fails with
```
 (cd _build/default && /home/opam/.opam/4.08/bin/ocamlc.opt -w -40 -g -bin-annot -I src/.es.eobjs -I /home/opam/.opam/4.08/lib/atd -I /home/opam/.opam/4.08/lib/atdgen -I /home/opam/.opam/4.08/lib/base -I /home/opam/.opam/4.08/lib/base/caml -I /home/opam/.opam/4.08/lib/base/md5 -I /home/opam/.opam/4.08/lib/base/shadow_stdlib -I /home/opam/.opam/4.08/lib/base_bigstring -I /home/opam/.opam/4.08/lib/base_quickcheck -I /home/opam/.opam/4.08/lib/bin_prot -I /home/opam/.opam/4.08/lib/bin_prot/shape -I /home/opam/.opam/4.08/lib/biniou -I /home/opam/.opam/4.08/lib/bytes -I /home/opam/.opam/4.08/lib/core_kernel -I /home/opam/.opam/4.08/lib/core_kernel/base_for_tests -I /home/opam/.opam/4.08/lib/core_kernel/rope -I /home/opam/.opam/4.08/lib/curl -I /home/opam/.opam/4.08/lib/devkit -I /home/opam/.opam/4.08/lib/devkit/core -I /home/opam/.opam/4.08/lib/easy-format -I /home/opam/.opam/4.08/lib/extlib -I /home/opam/.opam/4.08/lib/extunix -I /home/opam/.opam/4.08/lib/fieldslib -I /home/opam/.opam/4.08/lib/jane-street-headers -I /home/opam/.opam/4.08/lib/libevent -I /home/opam/.opam/4.08/lib/lwt -I /home/opam/.opam/4.08/lib/lwt/unix -I /home/opam/.opam/4.08/lib/mmap -I /home/opam/.opam/4.08/lib/netstring -I /home/opam/.opam/4.08/lib/netsys -I /home/opam/.opam/4.08/lib/oUnit -I /home/opam/.opam/4.08/lib/ocaml/threads -I /home/opam/.opam/4.08/lib/parsexp -I /home/opam/.opam/4.08/lib/pcre -I /home/opam/.opam/4.08/lib/ppx_assert/runtime-lib -I /home/opam/.opam/4.08/lib/ppx_bench/runtime-lib -I /home/opam/.opam/4.08/lib/ppx_compare/runtime-lib -I /home/opam/.opam/4.08/lib/ppx_enumerate/runtime-lib -I /home/opam/.opam/4.08/lib/ppx_expect/collector -I /home/opam/.opam/4.08/lib/ppx_expect/common -I /home/opam/.opam/4.08/lib/ppx_expect/config -I /home/opam/.opam/4.08/lib/ppx_hash/runtime-lib -I /home/opam/.opam/4.08/lib/ppx_inline_test/config -I /home/opam/.opam/4.08/lib/ppx_inline_test/runtime-lib -I /home/opam/.opam/4.08/lib/ppx_module_timer/runtime -I /home/opam/.opam/4.08/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.08/lib/re2 -I /home/opam/.opam/4.08/lib/re2/c -I /home/opam/.opam/4.08/lib/result -I /home/opam/.opam/4.08/lib/seq -I /home/opam/.opam/4.08/lib/sexplib -I /home/opam/.opam/4.08/lib/sexplib0 -I /home/opam/.opam/4.08/lib/splittable_random -I /home/opam/.opam/4.08/lib/stdio -I /home/opam/.opam/4.08/lib/time_now -I /home/opam/.opam/4.08/lib/typerep -I /home/opam/.opam/4.08/lib/variantslib -I /home/opam/.opam/4.08/lib/yojson -I /home/opam/.opam/4.08/lib/zip -no-alias-deps -o src/.es.eobjs/elastic_t.cmi -c -intf src/elastic_t.pp.mli)
 File "src/elastic_t.mli", line 4, characters 12-25:
 4 | type json = Yojson.Safe.t
                 ^^^^^^^^^^^^^
 Error: Unbound type constructor Yojson.Safe.t
```

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
fails with
```
=== ERROR while compiling uritemplate.0.1.0 ==================================#
 context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
 path                 ~/.opam/4.14/.opam-switch/build/uritemplate.0.1.0
 command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p uritemplate -j 255
 exit-code            1
 env-file             ~/.opam/log/uritemplate-7-995b8f.env
 output-file          ~/.opam/log/uritemplate-7-995b8f.out
 File "test/dune", line 3, characters 31-37:
 3 |   (libraries uritemplate oUnit atdgen))
                                    ^^^^^^
 Error: Library "atdgen" not found.
 -> required by _build/default/test/uritemplate_test.exe
 -> required by alias test/runtest in test/dune:2
```

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
they were transitively using some dependencies

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
uses Yojson.Safe.write_t

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
@mseri
Copy link
Copy Markdown
Member Author

mseri commented Jan 27, 2025

lint passed (kind of)

@mseri mseri merged commit e559add into ocaml:master Jan 27, 2025
@mseri mseri deleted the atd branch January 27, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant