test: verify transparent alias incremental build safety (#4572)#14101
Merged
rgrinberg merged 1 commit intoocaml:mainfrom Apr 10, 2026
Merged
test: verify transparent alias incremental build safety (#4572)#14101rgrinberg merged 1 commit intoocaml:mainfrom
rgrinberg merged 1 commit intoocaml:mainfrom
Conversation
robinbb
force-pushed
the
robinbb-issue-4572-safety-tests
branch
from
dbcdf0a to
2da8a3c
Compare
robinbb
changed the title
robinbb
force-pushed
the
robinbb-issue-4572-safety-tests
branch
from
2da8a3c to
47d7d81
Compare
rgrinberg
reviewed
Apr 9, 2026
test/blackbox-tests/test-cases/per-module-lib-deps/transparent-alias.t
Outdated
Show resolved
Hide resolved
Add baseline test verifying that incremental builds succeed when a module re-exports a library via a transparent alias (module M = Mylib) and the library's interface changes. Regression reported by @Alizter. Signed-off-by: Robin Bate Boerop <me@robinbb.com>
robinbb
force-pushed
the
robinbb-issue-4572-safety-tests
branch
from
47d7d81 to
6135bc9
Compare
Contributor
Author
|
I have applied your advice on this PR to others, also, @rgrinberg. Thank you. Back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a library via a transparent alias (
module M = Mylib) and the library'sinterface changes.
Safety test ensuring per-module dependency filtering (issue #4572) does
not break incremental builds for re-export/alias scenarios.
Ref: #4572
Test plan
dune runtest test/blackbox-tests/test-cases/per-module-lib-depspasses