test: verify library file deps in compilation rules and sandboxed builds (#4572)#14100
Merged
rgrinberg merged 1 commit intoocaml:mainfrom Apr 10, 2026
Merged
Conversation
robinbb
force-pushed
the
robinbb-issue-4572-test-deps
branch
from
31c2ce6 to
526fba8
Compare
robinbb
changed the title
This was referenced Apr 8, 2026
rgrinberg
reviewed
Apr 9, 2026
Contributor
Author
|
Back to you, @rgrinberg |
…lds (ocaml#4572) Add baseline tests documenting existing behavior: - lib-deps-preserved: every non-alias module declares glob deps on its library dependencies' .cmi files - sandbox-lib-deps: sandboxed package builds have dependency libraries' .cmi files available when a library depends on another library Signed-off-by: Robin Bate Boerop <me@robinbb.com>
robinbb
force-pushed
the
robinbb-issue-4572-test-deps
branch
from
d5c784f to
6ca78ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hidden_depsfromIncludesto per-module inbuild_cmlib-deps-preserved.t: every non-alias module declares glob deps on its library dependencies'.cmifilessandbox-lib-deps.t: sandboxed package builds have dependency libraries'.cmifiles available when a library depends on another libraryThese tests pass on
maintoday and establish a baseline for the refactor in #14030.Ref: #4572