test: document module name shadowing between stanza and library (#4572)#14031
Merged
Leonidas-from-XIV merged 1 commit intoocaml:mainfrom Apr 9, 2026
Merged
Conversation
Contributor
Author
|
@rgrinberg This PR is in response to your leading question on PR #14021 about shadowing. |
robinbb
force-pushed
the
robinbb-issue-4572-shadowing
branch
4 times, most recently
from
2fba4cc to
8ddbad3
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a new blackbox test suite under per-module-lib-deps/ to document current (coarse) recompilation behavior in Dune’s dependency analysis, plus a focused test documenting module-name shadowing between stanza-internal modules and unwrapped library modules (relevant to ocamldep-based filtering for #4572).
Changes:
- Add baseline tests showing that changes in a dependency (direct, transitive, virtual, wrapped/unwrapped, wrapped-compat) currently trigger broader recompilation than “per-module” would imply.
- Add a test that demonstrates stanza-internal module name shadowing takes precedence over an unwrapped library module of the same name.
- Add an opaque-mode test capturing the difference between release (opaque=false) and dev (opaque=true) recompilation behavior for implementation-only changes.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/blackbox-tests/test-cases/per-module-lib-deps/basic-wrapped.t | Baseline for wrapped library interface-change causing recompilation of unrelated executable modules. |
| test/blackbox-tests/test-cases/per-module-lib-deps/lib-to-lib-unwrapped.t | Baseline for coarse recompilation when an unwrapped library depends on an unwrapped multi-module library. |
| test/blackbox-tests/test-cases/per-module-lib-deps/lib-to-lib-wrapped.t | Baseline for coarse recompilation in a wrapped library-to-library dependency. |
| test/blackbox-tests/test-cases/per-module-lib-deps/module-name-shadowing.t | Documents module name shadowing behavior between an executable’s internal module and an unwrapped library module. |
| test/blackbox-tests/test-cases/per-module-lib-deps/multiple-libraries.t | Baseline for coarse recompilation when an executable depends on multiple libraries and only one changes. |
| test/blackbox-tests/test-cases/per-module-lib-deps/opaque.t | Captures opaque-mode impact on recompilation for implementation-only changes (release vs dev profile). |
| test/blackbox-tests/test-cases/per-module-lib-deps/transitive.t | Baseline for recompilation driven by transitive dependency changes even for independent modules. |
| test/blackbox-tests/test-cases/per-module-lib-deps/unwrapped.t | Baseline for coarse recompilation when a single module in an unwrapped library changes. |
| test/blackbox-tests/test-cases/per-module-lib-deps/virtual-library.t | Baseline for recompilation behavior when a virtual library’s interface changes. |
| test/blackbox-tests/test-cases/per-module-lib-deps/wrapped-compat.t | Baseline for recompilation behavior involving wrapped-compat modules from (wrapped (transition ...)). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/blackbox-tests/test-cases/per-module-lib-deps/module-name-shadowing.t
Outdated
Show resolved
Hide resolved
Collaborator
|
The |
Contributor
Author
Okay, makes sense. Thanks for helping! |
robinbb
force-pushed
the
robinbb-issue-4572-shadowing
branch
4 times, most recently
from
7a7293a to
386b933
Compare
rgrinberg
reviewed
Apr 7, 2026
test/blackbox-tests/test-cases/per-module-lib-deps/module-name-shadowing.t
Show resolved
Hide resolved
robinbb
force-pushed
the
robinbb-issue-4572-shadowing
branch
2 times, most recently
from
e6a4358 to
673f6db
Compare
Leonidas-from-XIV
requested changes
Apr 8, 2026
test/blackbox-tests/test-cases/per-module-lib-deps/module-name-shadowing.t
Outdated
Show resolved
Hide resolved
test/blackbox-tests/test-cases/per-module-lib-deps/module-name-shadowing.t
Outdated
Show resolved
Hide resolved
robinbb
force-pushed
the
robinbb-issue-4572-shadowing
branch
from
3f4a328 to
3d1f5ad
Compare
Contributor
Author
|
@Leonidas-from-XIV Addressed your concerns. Please have a look. |
Leonidas-from-XIV
requested changes
Apr 8, 2026
Collaborator
Leonidas-from-XIV
left a comment
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
I have one more concern that I probably missed in the last review.
test/blackbox-tests/test-cases/per-module-lib-deps/module-name-shadowing.t
Outdated
Show resolved
Hide resolved
When an internal module name shadows an unwrapped library's module name, the internal module takes precedence and the library's module is inaccessible. This means ocamldep will report the internal module, not the library's, so dependency filtering that treats stanza-internal names as non-library references is correct. Signed-off-by: Robin Bate Boerop <me@robinbb.com>
robinbb
force-pushed
the
robinbb-issue-4572-shadowing
branch
from
3d1f5ad to
aae05cd
Compare
Contributor
Author
|
@Leonidas-from-XIV Thanks for your review. Much appreciated. I have addressed your concerns. Care to review again (and merge if merited)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test documenting module name shadowing behavior between a stanza's
internal modules and an unwrapped library dependency.
When an executable has a module
Helperand also depends on an unwrappedlibrary that exposes a module
Helper, the internal module takes precedence:the build succeeds using the internal module, and the library's
Helperisinaccessible (
Unbound value).This behavior is relevant to #4572 (finer dependency analysis between
libraries), where
ocamldepoutput is used to determine which libraries amodule references. Since the compiler resolves shadowed names to the internal
module,
ocamldepreports the internal name — filtering it out asstanza-internal (rather than treating it as a library reference) is correct.
Ref: #4572