Add column width settings#170
Closed
ErikaRS wants to merge 204 commits intoobsidianmd:masterfrom
Closed
Conversation
updated read me
- Add task selection state store for tracking selected tasks - Update checkbox to toggle selection when in selection mode - Add visual feedback for selected tasks (checkmark with default icon color) - Display selection count in column header (with reserved space to prevent UI shift) - Clear selection state when switching back to Done mode (ephemeral) - Make toggle buttons minimal width - Use default icon color for selected/completed tasks for better visibility Created in collaboration with Amp (https://ampcode.com) Amp-Thread-ID: https://ampcode.com/threads/T-378d6363-0509-428d-b6f8-491a2327bf60 Co-authored-by: Amp <amp@ampcode.com>
Implemented bulk actions menu in column header that appears when tasks are selected in selection mode. Menu matches the per-task menu design with Move to [Column], Move to Done, Archive task, and Delete task options. Selections are cleared after bulk actions but selection mode persists for continued bulk operations. Resolves phase 6 of task interaction controls design. Created in collaboration with Amp (https://ampcode.com) Amp-Thread-ID: https://ampcode.com/threads/T-03808989-8476-46ca-a722-a64135986d9a Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-03808989-8476-46ca-a722-a64135986d9a Co-authored-by: Amp <amp@ampcode.com>
- Add comprehensive ARIA labels to all interactive elements - Implement full keyboard navigation (Tab, Enter, Space) for all controls - Add focus indicators using :focus-visible for better accessibility - Add aria-pressed states for toggle buttons - Add aria-live region for selection count announcements - Clear task selections when filters change to prevent stale state - Move selection count and bulk actions menu inline with mode toggle - Remove task card divider for more compact layout - Always reserve space for bulk actions button to prevent UI jiggle Created in collaboration with Amp (https://ampcode.com) Amp-Thread-ID: https://ampcode.com/threads/T-04d44890-6393-4372-a289-d947d1e1c51e Co-authored-by: Amp <amp@ampcode.com>
All phases of the Task Interaction Controls feature have been implemented: - Card layout restructure - Move to Done action - Navigate to file action - Selection mode toggle - Task selection in selection mode - Bulk action menu - Accessibility improvements and compact UI Created in collaboration with Amp (https://ampcode.com) Amp-Thread-ID: https://ampcode.com/threads/T-04d44890-6393-4372-a289-d947d1e1c51e Co-authored-by: Amp <amp@ampcode.com>
Created in collaboration with Amp (https://ampcode.com) Amp-Thread-ID: https://ampcode.com/threads/T-001914f0-8dc6-4ea1-b64f-833ae00a5e16 Co-authored-by: Amp <amp@ampcode.com>
Document new features added in v1.3.0: - Quick task completion with circle icon and toggle support - Navigate to file from task card - Selection mode toggle for bulk operations - Bulk actions menu for selected tasks Created in collaboration with Amp (https://ampcode.com) Amp-Thread-ID: https://ampcode.com/threads/T-951432ed-89f4-4d73-b733-e6d528a35505 Co-authored-by: Amp <amp@ampcode.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [js-yaml](https://github.com/nodeca/js-yaml). Updates `js-yaml` from 3.14.1 to 3.14.2 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
…arn-4265e88a4c chore(deps-dev): bump js-yaml from 3.14.1 to 3.14.2 in the npm_and_yarn group across 1 directory
Amp-Thread-ID: https://ampcode.com/threads/T-68b76b8d-46b0-44b6-81fe-3f081c0accd6 Co-authored-by: Amp <amp@ampcode.com>
This change adds CSS properties to the task card file path element to ensure that long file names wrap correctly instead of overflowing. - Uses overflow-wrap: anywhere to handle long strings - Uses min-width: 0 and flex: 1 to work correctly within flexbox - Adds line-height for better readability Created in collaboration with Amp (https://ampcode.com) Amp-Thread-ID: https://ampcode.com/threads/T-04063e7e-edba-4493-919b-8721e7589833 Co-authored-by: Amp <amp@ampcode.com>
- Default new tasks to 'TODO' content so they are not empty - Ensure empty tasks have a minimum height so they are clickable - Vertically center single-line task content Created in collaboration with Amp (https://ampcode.com) Amp-Thread-ID: https://ampcode.com/threads/T-e9c009fd-b802-4a24-abd1-344e58c6cdbe Co-authored-by: Amp <amp@ampcode.com>
- Update kebab function to preserve forward slashes, enabling nested tag support (e.g. #Parent/Child) - Update task serialization to use original column casing from settings instead of normalized keys - Add documentation on tag mapping behavior to README Created in collaboration with Amp (https://ampcode.com) Amp-Thread-ID: https://ampcode.com/threads/T-b0060e0a-f141-4fb5-b9c3-5b0140eec69f Co-authored-by: Amp <amp@ampcode.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Created in collaboration with Amp (https://ampcode.com)
Refactored the monolithic AGENTS.md into focused documentation files: - README.development.md - README.process.md - README.planning.md - README.architecture.md AGENTS.md now serves as a lightweight entry point with quality gates. Added CLAUDE.md to redirect to AGENTS.md. Created in collaboration with Amp (https://ampcode.com) Amp-Thread-ID: https://ampcode.com/threads/T-6dfd045a-8ada-429c-b47e-df95be5c8236 Co-authored-by: Amp <amp@ampcode.com>
- Added isValidTag helper to check if a tag matches Obsidian's tag rules. - Updated Task.serialise to fall back to kebab-case column name if the display name is not a valid tag. - Added regression tests for columns with spaces and special characters. Amp-Thread-ID: https://ampcode.com/threads/T-4c3c85d2-702c-454b-b0be-c5cb82229412 Co-authored-by: Amp <amp@ampcode.com>
Create comprehensive specification for configurable column width and multi-directional column flow (LTR, RTL, top-to-bottom, bottom-to-top). Key aspects covered: - Column width configuration (200-600px range) - Four flow directions with appropriate semantics - Corner cases: width meaning in vertical flows, RTL with sidebar, drag-and-drop compatibility, dimension constraints - Phased implementation plan (5 phases) - Accessibility and i18n considerations - Edge case handling for empty columns, task cards, scrolling Addresses user needs for screen space optimization, RTL language support, and alternative workflow preferences.
Major corrections after verifying actual implementation: 1. Width semantics: Setting ALWAYS controls horizontal card width - Card height is ALWAYS auto-calculated (current behavior) - In vertical flows, columns maintain horizontal width but stack - No width→height conversion needed - Rationale: Cards need readable width; height auto-sizes to content 2. Verified current implementation details: - Cards have NO fixed height (only min-height: 1.5rem, max img: 160px) - Textarea dynamically resizes to content - Column uses align-self: flex-start for auto-height - "Add new" button is at BOTTOM of task list (not top) - All column controls are at TOP (header, mode toggle) 3. Keyboard navigation: Not an issue - No arrow key navigation between columns exists - Only Enter/Space for button activation - Removed from open questions (verified) 4. Updated corner cases with verified behavior: - Vertical flow dimensions - Task card layout (unchanged in all flows) - Button positioning - Empty column drop zones (50px min-height) 5. Simplified CSS architecture: - No special height rules for vertical flows - Existing align-self: flex-start handles auto-height - Column width CSS var applies to horizontal dimension only This corrected design is simpler and matches how physical kanban boards work when oriented vertically.
…c-xE98p Claude/column width direction spec
Implements configurable column width as specified in SPEC_0005 Phase 1: - Add columnWidth setting (200-600px range, default 300px) - Zod schema validation with min/max constraints - CSS variable --column-width applied to columns - Slider UI in settings modal with live updates - Settings persist across sessions via frontmatter Changes: - src/ui/settings/settings_store.ts: Add columnWidth to schema and defaults - src/ui/components/column.svelte: Use CSS variable for width - src/ui/main.svelte: Extract columnWidth from settings and apply to columns - src/ui/settings/settings.ts: Add slider UI component (200-600, step 10) The width setting controls horizontal card width in all flow directions (preparing for Phase 2-4 flow direction implementations).
Add script to copy plugin files (main.js, manifest.json, styles.css) to Obsidian test instance. Uses OBSIDIAN_TEST_INSTANCE environment variable or accepts custom path as argument. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…irection-phase-one-TfBfM
Add 8 tests for Phase 1 column width configuration: - Default value (300px) when missing - Valid value parsing - Minimum/maximum boundary values (200px/600px) - Invalid value rejection with fallback - Serialization and round-trip persistence Ensures columnWidth setting validates correctly and falls back to safe defaults when invalid values are provided. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Phase 1 implementation is complete with all requirements fulfilled: - Column width configuration (200-600px range) - Settings UI with slider component - CSS variables and reactive updates - Validation and persistence - 8 automated tests for edge cases - Manual verification in Obsidian passed All 11 Phase 1 tasks completed and verified. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Author
|
Ugh. Ignore this. It got main on the wrong repo when I was trying remote Claude Code :-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #72 (will mark as fixed after deployment)