Add NullableCondition extension for Condition#817
Open
nickolasdeluca wants to merge 1 commit into
Open
Conversation
Introduce a NullableCondition<T> extension on Condition<T>? providing and(Condition<T>) and or(Condition<T>) helpers. These methods return the provided condition when the receiver is null, or delegate to the existing and/or logic otherwise, simplifying conditional accumulation of query conditions and removing boilerplate null checks. Doc examples included to demonstrate usage when building queries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
NullableCondition<T>extension onCondition<T>?providingand(Condition<T>)andor(Condition<T>)helpers.These methods return the provided condition when the receiver is null, or delegate to the existing and/or logic otherwise, simplifying conditional accumulation of query conditions and removing boilerplate null checks. Doc examples included to demonstrate usage when building queries.
Usefull when building queries with multiple condition options that can all be supplied as null.
Example:
I always write this extension on all my projects because it makes it much easier to work with lots of conditions. Since
Conditionitself is not nullable, I'd always have to kick start it with something likeCity_.id.greaterThan(0)and then add my conditional conditions (haha).Providing this extension natively should help everyone, I hope.