Skip to content

Update build - #43

Merged
dupondje merged 5 commits into
masterfrom
update_build
Aug 25, 2026
Merged

dupondje merged 5 commits into
masterfrom
update_build

Conversation

@dupondje

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
@dupondje dupondje self-assigned this Jul 17, 2026
@dupondje
dupondje force-pushed the update_build branch 2 times, most recently from 7e2dbc5 to fad36eb Compare August 24, 2026 09:54
- Update the way version tags are added during build.
  Now we can tag a commit in github, and the correct version string will
  be used for the builds.
- Run the workflow on any tag, so it builds tags in branches also.
- Drop copr

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Add SO_REUSEADDR to the server and client socket,
so we can reuse ports in TIME_WAIT state.

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Join the generator thread in order to make sure it fully finished before
trying to read the values from it.

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>

@JasperB-TeamBlue JasperB-TeamBlue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

When running the ServerSockerChannel with a Selector, the close() call
doesn't directly close the socket. This only happens after we trigger
the socket again.
So call selectNow() in order to really close the socket so we can rebind
it.

See https://bugs.openjdk.org/browse/JDK-5073504

Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>

@JasperB-TeamBlue JasperB-TeamBlue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dupondje
dupondje merged commit b8c678e into master Aug 25, 2026
10 checks passed
@dupondje
dupondje deleted the update_build branch August 25, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants