Skip to content

Optimize LIKE expressions in ArraySource filters. #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vanam wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize LIKE expressions in ArraySource filters. #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions src/DataSources/ArraySource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,38 @@ public function compare($actual, $condition, $expected)
$cond = str_replace(' ?', '', $condition);

if ($cond === 'LIKE') {
// Ignore accents
$actual = Strings::toAscii($actual);
$expected = Strings::toAscii($expected);

$pattern = str_replace('%', '(.|\s)*', preg_quote($expected, '/'));
return (bool) preg_match("/^{$pattern}$/i", $actual);
// Ignore case
$actual = strtolower($actual);
$expected = strtolower($expected);

$result = FALSE;

if (Strings::startsWith($expected, '%') && Strings::endsWith($expected, '%')) {
$expected = ltrim($expected, '%'); // remove starting %
$expected = rtrim($expected, '%'); // remove trailing %

// LIKE %s%
$result = Strings::contains($actual, $expected);
} elseif (Strings::startsWith($expected, '%')) {
$expected = ltrim($expected, '%'); // remove starting %

// LIKE %s
$result = Strings::endsWith($actual, $expected);
} elseif (Strings::endsWith($expected, '%')) {
$expected = rtrim($expected, '%'); // remove trailing %

// LIKE s%
$result = Strings::startsWith($actual, $expected);
} else {
// LIKE s
$result = $actual == $expected;
}

return $result;

} elseif ($cond === '=') {
return $actual == $expected;
Expand Down
5 changes: 5 additions & 0 deletions tests/DataSources/ArraySource.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ class ArraySourceTest extends DataSourceTestCase
Assert::true($source->compare('Žluťoučký kůň', 'LIKE ?', 'zlutou%'));
Assert::true($source->compare('Žluťoučký kůň', 'LIKE ?', 'žlutou%'));

$extraLongText = "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin nunc diam, maximus a imperdiet et, iaculis quis metus. Donec est turpis, pharetra a lacus nec, pellentesque volutpat velit. Nunc iaculis ipsum in nisl porta, non ornare enim dapibus. Vestibulum a arcu fermentum, semper est vitae, congue odio. Vestibulum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia curae; Sed accumsan sapien at tempus feugiat. Mauris sit amet quam ultricies, hendrerit massa sit amet, posuere turpis.";
Assert::true($source->compare($extraLongText, 'LIKE ?', "%{$extraLongText}%"));
Assert::true($source->compare("some prefix " . $extraLongText, 'LIKE ?', "%{$extraLongText}"));
Assert::true($source->compare($extraLongText . " some sufix", 'LIKE ?', "{$extraLongText}%"));

Assert::true($source->compare('Lucie', '=', 'Lucie'));
Assert::false($source->compare('Lucie', '=', 'lucie'));

Expand Down