feat: add story for @nuxt/fonts module#946
Open
hacknug wants to merge 11 commits intonuxt-modules:mainfrom
Open
feat: add story for @nuxt/fonts module#946hacknug wants to merge 11 commits intonuxt-modules:mainfrom
@nuxt/fonts module#946hacknug wants to merge 11 commits intonuxt-modules:mainfrom
Conversation
👷 Deploy request for nuxt-storybook pending review.Visit the deploys page to approve it
|
Contributor
Author
|
@tobiasdiez everything seems to be working ok on my end (both with nuxt and storybook dev). Not sure why Showcase doesn't show the fonts on the only link I can see. Maybe fonts aren't being deployed as part of storybook standalone? Solution only works for the default path: https://fonts.nuxt.com/get-started/configuration#assets Should we add a mention in the docs? Make it configurable? Try to re-use the user provided config for the fonts module? EDIT: Sorry it took me a while to get to this, I've been busy and I finally managed to make some time to look into this solution I had in my head for a while haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#820
Supersedes #921 because I'm a moron and made my changes to
mainon a auto-deleted codespace 😅📚 Description
This PR adds a
NuxtFontscomponent and a story to check if the@nuxt/fontsmodule is working correctly inside Storybook. At the moment, IT DOES NOT.It also adds a
/modules/fontsroute to test the module is working correctly inside the app which IT DOES.